351678 - Camino hangs at launch due to site icon lookups for bookmarks, a PAC proxy, and DNS

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Bookmarks, defect)

Description

[Andreas Böckler]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; de-de) AppleWebKit/418.8 (KHTML, like Gecko) Safari/419.3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.4) Gecko/20060613 Camino/1.0.2 (MultiLang)

Apparantly Camino tries to resolve all InetAddresses in my bookmark file (very big).
tcpdump shows me many domain-lookups, when I'm starting camino
If there is any domain which cannot be resovled (eg. www.linux-center.org), the process stalls for a moment. 
The "stall time" is many times longer with a big bookmark file.
I have to wait about 1-2 minutes before i can use Camino.

Reproducible: Always

Steps to Reproduce:
1. create bookmarks with domains, where the dns-server is not online (DNS-Timeout), e.g. www.linux-center.org
2. Close Camino
3. Start Camino 

Actual Results:  
After some time (10-20 seconds) Camino starts to stall/lock up.
The time you have to wait is proportional to the size of your bookmark list (with DNS timeouts)

Expected Results:  
No lockup.

Firefox and Mozilla did't have the problem. I'm using my bookmark list many years under linux.
Does it have to do with spotlight?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon, this is the favicon lookup (bug 327452) again, isn't it?

Comment 2

[Andreas Böckler]

After reading the other bug report, I can somehow clarify things.

I'm using a .pac-File with
isInet()-Calls ..
after disabling the .pac and switching to static proxy-settings the timeout-problem is gone, since Camino doesn't have to make dns-Lookups.

Comment 3

[Simon Fraser [no longer active]]

Right, it's a combination of site icons and the PAC file.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This is a bug, and we know it.  I wish we knew how to fix it.

Comment 6

[benc]

Why do you lookup the hostnames of the site icons? Isn't that bad, esp. since we don't support an offline mode?

Using isInNet is bad. I never finished my technical guide to pac, but that and IsResolvable() is largely useless, if you know anything about DNS and network management. The guy that wrote the PAC spec, Ari, admitted that it was laregly a unusable feature, (when I worked at Netscape.)

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I wonder if this is really bug 235853 (which went in and then right back out tonight)?

(In reply to comment #6)
> Why do you lookup the hostnames of the site icons?

If this hang is bug 235853, our site icon lookup might still be a Camino bug (or a feature, depending whether it exacerbates the "disappearing site icons" behavior or not).

Comment 10

[benc]

Do we have anything like Error log? You can put some alert statements into the PAC file to see what is going on. I still don't understand the underlying behavior. Are you saying the bookmark icons are refreshed to make sure they are current? Isn't that some really high-bandwith/low-value activity?

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Even when I comment out http://mxr.mozilla.org/camino/source/camino/src/bookmarks/BookmarkManager.mm#373 and http://mxr.mozilla.org/camino/source/camino/src/bookmarks/BookmarkManager.mm#393, I still see 

Oct 18 20:03:08 Qalaat-Samaan Camino[2464]: Site icon load http://www.google.com/favicon.ico dispatched 1
Oct 18 20:03:08 Qalaat-Samaan Camino[2464]: Site icon load http://www.amazon.com/favicon.ico dispatched 1
Oct 18 20:03:09 Qalaat-Samaan Camino[2464]: Site icon load about:blank dispatched 1
Oct 18 20:03:09 Qalaat-Samaan Camino[2464]: Site icon load http://www.google.com/favicon.ico done, status 0x804B0046
Oct 18 20:03:09 Qalaat-Samaan Camino[2464]: Site icon load http://www.amazon.com/favicon.ico done, status 0x804B0046
Oct 18 20:03:09 Qalaat-Samaan Camino[2464]: Site icon load about:blank done, status 0x00000000
Oct 18 20:06:10 Qalaat-Samaan Camino[2464]: Site icon about:blank known missing

in a default profile.  Google and Amazon are the two sites in the root of the Bookmarks Toolbar in a default profile, and I have no idea why they are being pinged when I've commented that out.

I also completely don't understand the site icon provider code; it's only supposed to be looking up site URL to icon URL (to site icon cache) mappings, and I don't know why any of that would be hitting the network (which this bug and others like it, and some logging I've done various places for other bugs, shows is clearly happening).