351871 - NativeData2JS does not handle unsigned 64 bit correctly

Status: RESOLVED INACTIVE

(Core :: XPConnect, defect)

Description

[jhp (no longer active)]

Due to the definition of JAM_DOUBLE_U64  (http://lxr.mozilla.org/mozilla/source/js/src/xpconnect/src/xpcconvert.cpp#176) in xpcconvert.cpp, unsigned 64 bit values are treated as signed values, which leads to incorrect values for large unsigned 64 bit numbers.  It seems like the correct thing to do is to use LL_L2D, as is done in the #else block for the code.

Comment 1

[jhp (no longer active)]

Attachment: patch

Something like this.  The comment for JAM_DOUBLE_U64 says that "Win32 can't handle uint64 to double conversion", but this worked just fine for me on WinXP.  Maybe older Win32 systems?

Comment 2

[jhp (no longer active)]

Comment on attachment 237375 [details] [diff] [review]
patch

Nope, this patch is wrong; my testcase was incorrect. Unsigned still treated as signed.

Comment 3

[jhp (no longer active)]

Attachment: patch v1.1

This is better.  However, I haven't tested this on a Win32 machine.

Comment 4

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.