35419 - solaris/gcc should use -shared instead of -G in configure.in DSO_LDOPTS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dan Mosedale (:dmosedale, :dmose)]

This is the Right Way to generate a shared object under GCC.  It adds "-z text"
to the linker flags, and perhaps does other stuff too.

I've been having some problems with the "-z text" and
nsScriptSecurityManager.cpp which I need to resolve before I can get this in.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Because of the "-z text", 35418 needs to be fixed first.

Also, one reason why using "-shared" is desirable is because of this (quoted
from bug 23759):

> By default, the solaris linker is willing to link non-PIC code into shared
> libraries.  If someone has their LD_LIBRARY_PATH set in an unusual way, this
> can cause errors that are subtle and difficult to track down.
>
> Adding "-z text" to DSO_LDOPTS on solaris will instead cause the linker to
> abort if it stumbles across non-PIC code while linking a shared library.

Comment 2

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Reassigning Solaris-specific bugs to richb.

Comment 4

[Rich Burridge]

Reassigning to Sherry Shen.

Comment 5

[Rich Burridge]

Reassigning to me. Sherry no longer works on Mozilla.

Comment 6

[Rich Burridge]

Reassigning to Herbie, who has a fix in hand for this bug.

Comment 7

[Brendan Eich [:brendan]]

Please attach patches and get reviewers to record their stamps of approval in 
the bug, next time.  Thanks.  a=[e-mail].

/be

Comment 8

[Herbie]

Attachment: for gcc builds, modified DSO_LDOPTS to use -shared instead of -G

Comment 9

[Herbie]

Just addded the patch, already got r=[e-mail] last week, I forgot
to mark it down here.  I will check in fix soon.

Comment 10

[cls]

Herbie, I checked in your patch this afternoon and speedracer (the solaris/gcc
tinderbox) broke.  Besides not having a dynamic libstdc++ (which dmose fixed!
rheeeeeeeeet!) , it turns out that we link against libiberty.a for debug builds
and of course, libiberty.a is not compiled with -fPIC so the build fails.  If
you know of a better way to demangle C++ names other than using libiberty's
cplus_demangle() function, please let us know and we can try this patch again.

Comment 11

[Frank Belew]

Here's some voodoo for you

on the gcc line for linking ....

-Wl,-B,static -liberty -Wl,-B,dynamic -l<other libs>

This will direct the linker to link that lib static, and everything after it 
dynamically, of course

Comment 12

[drapeau]

Re-assiging to Rich Burridge; Herbie no longer works on Mozilla.

Comment 13

[Rich Burridge]

Reassigning to Ed to do with as he wants.

Comment 14

[edburns]

I'll ask our RE person to look at this.

Comment 15

[edburns]

We're probably going to close this as WONTFIX since we're moving to getting 
everyone to build with Forte.

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Please don't close it; Mozilla needs to continue to work nicely with free
compilers.  WONTFIXing is especially inappropriate given that solaris/gcc is on
the tinderbox main page.  If you can't possibly devote any cycles to this,
consider posting to .unix and .builds and asking if there's anyone who would be
willing to take this bug off your hands.  Worst case, reassign to
[e-mail] and add a helpwanted keyword.

Comment 17

[Axel Hecht]

Hi Ed,
as long as compiling mozilla with forte requires at least glib to be compiled 
with forte, please proceed with a bit more caution.

No cycles here, either, though.

Axel

Comment 18

[cls]

Patch has been rechecked in now that we no longer use libiberty.

Comment 19

[cls]

Ok, this patch has been backed out (again).  After making sure that every
Mozilla library was compiled with -fPIC and doing some googling, it looks like
something else is causing ld to throw the 'relocations remain against
allocatable but non-writable sections' error.  Adding -mimpure-text to
DSO_LDOPTS got the build to finish on speedracer but that's apparently not a
recommended option: see http://gcc.gnu.org/ml/gcc-patches/2002-11/msg01815.html
.  And it either only works for libraries created with g++ or it wasn't
implemented in egcs 1.0.3 so bismark is still dying when linking
libmoz_libart_lgpl.so which is a C library.

I'm guessing that gcc is Doing Something Wrong(tm) because it complains about
the text allocations in nsComputedDOMStyle.cpp which is being compiled with
-fPIC.  One thing I did notice though is that file contains a lot of functions
with have each have a const variable of varying types named "text". 

Comment 20

[Nicolai Stange]

The problem still remains, and since siy years are gone and thus, the side effects of the above patch might have changed, I start out with a new diff for discussion.

There is one other problem regarding gcc/solaris linker flags: The -rpath-link within the MOZ_FIX_LINK_PATHS.

The diff has been made against the current firefox 3.6.9 release.

Are the guys in CC still involved or does it make sense to add some general email like bugs@... to it?

Comment 21

[Nicolai Stange]

Attachment: Basis for restarting the discussion

against firefox release 3.6.9

Comment 22

[Mike Hommey [:glandium]]

This was fixed in bug 574639.