35503 - Menus don't draw when using overflow:auto internally

Status: VERIFIED WORKSFORME

(Core :: Layout, defect, P3)

Description

[Mike Pinkerton (not reading bugmail)]

In xul.css, make sure the css rules for menupopup/popup are as follows:

menupopup {
  behavior: url("resource:/chrome/xulBindings.xml#popups");
  display: none;
}

popup {
  behavior: url("resource:/chrome/xulBindings.xml#popups");
  display: none;
}


then in xulBindings.xml, make the XBL impl for popups be a box with overflow set:

  <binding name="popups">
    <content>
      <xul:box class="internal-box" orient="vertical" flex="1" style=
"overflow:auto;">
        <children/>
      </xul:box>
    </content>
  </binding>
  
Now notice that menus or popups on the personal toolbar no longer draw correctly. 
evaughan and hyatt think this has to do with the fact that overflow:auto creates 
extra subviews (to handle scrolling) that don't play nicely with the floating 
view in the popup.

Comment 1

[Mike Pinkerton (not reading bugmail)]

marking as a blocker.

Comment 2

[Mike Pinkerton (not reading bugmail)]

marking as a blocker, need this for my feature which is committed to for m16.

Comment 3

[Kevin McCluskey (gone)]

I dumped the location of the text frames in nsContainerFrame::PaintChild
     ...
    aRenderingContext.Translate(-kidRect.x, -kidRect.y);
    printf("Kid Rect position %d %d \n", kidRect.x, kidRect.y);
     ...

When the menu popup's are displayed and overflow is set to clip the text frame's 
have the correct position. When overflow is set to auto the text frame's are set 
to 0,0.

Since the frames have the wrong translation, either they must not be getting 
reflowed, or they are being reflowed to 0,0. I also tried adding a hover rule 
for a menu item which expanded its font-size to force a reflow. This did NOT fix 
the layout of the menuitems in the dropdown. 

Changing component to layout.

Reassigning to Eric, and CC'ing troy since overflow:auto does not reflow 
the frames correctly within popup's.

Comment 4

[Peter Trudelle]

This is blocking one of our features, need an owner who can work on it 
immediately, and an estimated landing date. Is this really Mac-specific?

Comment 5

[Kevin McCluskey (gone)]

This is not Mac specific. I was able to get it to fail on WINNT. Changing 
platform to ALL.

Comment 6

[Eric Vaughan]

Work complete testing on multiple platforms.

Comment 7

[Peter Trudelle]

nominating for nsbeta2

Comment 8

[Eric Vaughan]

Scrolling menus now work on both window and linux. But its problematic on mac. 
Saari is looking at it.

Comment 9

[Peter Trudelle]

[nsbeta2+]

Comment 10

[saari (gone)]

it looks like whatever problems we were having with scrolling menus on MacOS were 

fixed in the last week, probably by pinkerton. They work fine for me now.



WORKSFORME unless I'm missing something...

Comment 11

[saari (gone)]

marking worksforme

Comment 12

[Chris Petersen]

Mike, I'm not seeing a problem with the May 30th build. All items on the personal 
tool bar appear current (including the bookmarks pop-menu). Is there something 
I'm missing here ?

Comment 13

[Mike Pinkerton (not reading bugmail)]

Chris, i think this is ok now, and all problems are covered in separate bugs.

Comment 14

[Chris Petersen]

Fixed in the June 19th build (2000061908).