Closed Bug 36570 Opened 24 years ago Closed 24 years ago

signature shows up in middle of quoted text

Categories

(MailNews Core :: Composition, defect, P3)

Product:
MailNews Core
Component:
Composition
Platform:
All
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: akkzilla, Assigned: mozeditor)

References

Details

(Whiteboard: [nsbeta2-][7/14]) 

4/20 linux debug build: I send myself a plaintext message that says:

one
two
three

then read it with mozilla and reply to it in an html compose window.
I have a simple plaintext signature.  When the compose window comes up, the
signature is in the middle of the quoted text.  Here's the html content of the
compose window (from Debug->OutputHTML):

<html><head></head><body>akkana@netscape.com (Akkana Peck) wrote:<br>
<blockquote type="cite" cite="38FF6417.A6A66529@netscape.com">
<pre wrap>
one<br>
two<br>
<pre>
--<br>
    ...Akkana<br>
    Sent with Mozilla mail; please report any weirdness<br>
</pre>
<br>
three<br>
</pre>
</blockquote>
<br>
<br>
</body>
</html>

I'm not sure if this is 100% reproducible, but I did it twice in a row and got
the same thing both times.
Accepting, M17
Status: NEW → ASSIGNED
Target Milestone: --- → M17
Mail Review recommends this bug as beta2 stopper.  Adding nsbeta2 keyword.
Keywords: nsbeta2
Putting on [nsbeta2+] radar for beta2 fix.
Whiteboard: [nsbeta2+]
*** Bug 39252 has been marked as a duplicate of this bug. ***
100% reproducable for me.
QA Contact: lchiang → pmock
Assignee: ducarroz → rhp
Status: ASSIGNED → NEW
to me
Will look into this over the weekend.

- rhp
Status: NEW → ASSIGNED
I tried this on linux and it seemd to work for me...can someone verify?

- rhp
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → WORKSFORME
Bug still appears for me on build from am Jun 24 21:37:02 CEST 2000.

I am using a plain text signature (|/home/<user>/.signature|), content:
<http://www.bucksch.org>
and replying via HTML composer.
I can reproduce this bug on win32, linux, and macos. The builds I tested with 
were as follow:
 Win32 commerical seamonkey builds 2000-062509-m17 and 2000-062609-m17
 Linux commerical seamonkey builds 2000-062509-m17 and 2000-062610-m17
 MacOS commercial seamonkey builds 2000-062508-m17 and 2000-062608-m17

Re-openning bug.

Steps to reproduce bug
 1) From Communicator 4.72, send yourself a plain text message that contains a 
signature
 2) Launch Seamonkey
 3) Select the Edit menu and choose Mail & News Account setting
 4) Select a signature file
    Be sure to select signature file that is different from the one used in 
4.72.  It will make it easier to identify.
 5) Enable the check box to include a signature
 6) Enable the option to use html composer editor
 7) Save the changes
 8) REtrieve you mail message from 4.72
 9) Select the message
    The message loads with with the signature
 10) Click on the reply button off the toolbar
     The original signature is removed but the new signature is inserted in the 
middle of the quoted text.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
changing platform to "ALL"
Hardware: PC → All
Interestingly, with my fix for bug 39370, the signature is places correctly, if
I reply to a format=flowed msg. It is still misplaced for replying to plain text
and html. Maybe this gives you any clue for hunting the bug.
Status: REOPENED → ASSIGNED
Hi Akkana,
I think this may either be an editor problem or something with the code I am 
trying to execute. Here is what I am doing:

  // Now, insert it into the editor...
  if ( (aQuoted) )
  {
    if (!aPrefix.IsEmpty())
    {
      if (aHTMLEditor)
        aEditorShell->InsertSource(aPrefix.GetUnicode());
      else
        aEditorShell->InsertText(aPrefix.GetUnicode());
    }

    if (!aBuf.IsEmpty())
    {
      if (!mCiteReference.IsEmpty())
        aEditorShell->InsertAsCitedQuotation(aBuf.GetUnicode(), 
mCiteReference.GetUnicode(),
                                             PR_TRUE,
                                             
NS_ConvertASCIItoUCS2("UTF-8").GetUnicode(), getter_AddRefs(nodeInserted));
      else
        aEditorShell->InsertAsQuotation(aBuf.GetUnicode(), 
getter_AddRefs(nodeInserted));
    }

    if (!aSignature.IsEmpty())
    {
      if (aHTMLEditor)
        aEditorShell->InsertSource(aSignature.GetUnicode());
      else
        aEditorShell->InsertText(aSignature.GetUnicode());
    }
  }

The problem I am seeing is that the final InsertSource/InsertText is being made 
part of the blockquote. Is there something I have to call before that insert?

- rhp
Assignee: rhp → akkana
Status: ASSIGNED → NEW
added fix by date in status
Whiteboard: [nsbeta2+] → [nsbeta2+][8/2]
Sounds like an edit rules question for Joe.
Assignee: akkana → jfrancis
accepting bug; i have some ideas.... setting ETA
Status: NEW → ASSIGNED
Whiteboard: [nsbeta2+][8/2] → [nsbeta2+][7/14]
Moving from [nsbeta2+] to [nsbeta2-] per todays Composer QA Beta2 Status review.
Whiteboard: [nsbeta2+][7/14] → [nsbeta2-][7/14]
Keywords: nsbeta3
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Linux (2000-07-24-08 M17)
Win32 (2000-07-24-11 M17)
This problem does not exist on Linux and Win32 any more. Will re-test Mac
Mac (2000-07-24-08 M17)
OK. I used Peter's scenario and re-test it on Mac. No problem any more.
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.