36975 - [IME 2000]-Moving caret in Convert mode does not work

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P2)

Description

[Teruko Kobayashi]

(This bug imported from BugSplat, Netscape's internal bugsystem.  It
was known there as bug #384563
http://scopus.netscape.com/bugsplat/show_bug.cgi?id=384563
Imported into Bugzilla on 04/24/00 12:50)

IME 2000 has new feature which the user can move the cursor in Convert mode to delete the character. 

Steps of reproduce
1. Open Composer and change Character set to Japanese (Auto-Detect)
2. Turn on IME
3. Type Japanese characters "園芸展開に行く" (Engei tenkai ni iku), do not hit enter to commit
4. Hit Space bar to convert
5. Move the mouse to the end of 3rd double byte character

Expected result
It still in convert mode and the user put the cursor at the end of 3rd character without commit

Actural result
The characters are committed.

Tested 1-31a Win32 build under Windows 2000 JA Release Candidate.



------- Additional Comments From marek  Mar-03-2000 17:04 ------- 

reassigning I18N bugs to roberts

Comment 1

[Teruko Kobayashi]

This is new feature for IME 2000. Nominationg this for beta2 since the other IME 
2000 bug 18680 is the i18n beta2 criteria. Reassigned to [e-mail].

Comment 2

[bobj]

This bug, http://scopus.netscape.com/bugsplat/show_bug.cgi?id=384563,
is filed against 4.72, not Seamonkey.  That bug should be left open instead
of being closed as WONTFIX.  Sustaining might want to fix it post-4.72.

Is this reproducible on Seamonkey?  If so, this bug 36975 should remain
open, otherwise this should be closed.

Comment 3

[Teruko Kobayashi]

This happens in Seamonkey.  I tested in 2000042109 Win32 build under Win2000JA.
And I also reopen the 
bug, http://scopus.netscape.com/bugsplat/show_bug.cgi?id=384563 

Comment 4

[Frank Tang]

Is this a dup of 18680 ?

Comment 5

[Phil Peterson]

[nsbeta2-]

Comment 6

[Frank Tang]

reassign to shanjian- we may not have time to implement this for beta2 

Comment 7

[Makoto Kato [:m_kato]]

probably, you must use WM_MSIME_MOUSE and WM_MSIME_QUERYPOSITION message.
But I have no sample and addtional document.
And, this issue should be dup to bug 18680.

Comment 8

[Frank Tang]

nsbeta3+ per i18n bug meeting
add [e-mail] to the cc list. [e-mail], can you 
work with shanjian for remaining isue that jfrancis do not agree w/ ?

Comment 9

[Shanjian Li]

Kato san suggest some partial fixes, but there is one part missing. 
That is how could we get the composition offset base on mouse 
click position. Probably we need to implement a new event, and 
messing with mouse click message handling. My win2k will be down
for 2 wks. When it is up again, I should be able to propose a 
fix within a week. 

kato, if you have time in following 2 wks, can you do something 
about it? 

Comment 10

[Frank Tang]

I wonder we can fix this in Netscape6. The current IME arch does not support 
this. We have the same issue in Mac. We should nsbeta3- this one.

Comment 11

[Frank Tang]

Deside to cut this. nsbeta3- 4.x does not support this neither. mark it future

Comment 12

[Frank Tang]

reassign to yokoyama

Comment 13

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 14

[Kasumi]

tested 2002-04-12-08-1.0.0
OS = Win XP Pro. JA
This is not only Win 2000 problem.
It occures on Win XP JA also.
Win XP is a major criteria.
This is Win 2000 new feature which is issued more than 3 yeares ago, but  not
supported yet.
This is very poor quality. I added keyword nebeta1.
Bug 18680 is the similar.   

Comment 15

[nhottanscp]

nsbeta1-

This needs to be addressed after mozilla 1.0 but not for nsbeta1, there is a
workaround by using keyboard.

Comment 16

[Frank Tang]

reassign to shanjian and mark tm=1.2alpha, nsbeta1+ for m1.2final

Comment 17

[Shanjian Li]

accepting. 

Comment 18

[Shanjian Li]

I made some progress in this bug, but there is still some problem. Handling the
position of characters will be  a little bit complicated if we want to record
caret position each time. I assumed the current text frame will be the frame for
composing text only. However, after some experiment, I found out that this is
not true. I may have to monitoring the caret. 

Comment 19

[Shanjian Li]

Attachment: proposed patch 1.0

Comment 20

[Shanjian Li]

roy, would you mind take a look?

Comment 21

[Roy Yokoyama]

Comment on attachment 99598 [details] [diff] [review]
proposed patch 1.0

/r=yokoyama with indentation
fix at:
+    mIMECompCharPos = nsnull;

Comment 22

[Frank Tang]

shanjian, could you write a small html file to document how to add this support
? That will help us to understand what it take to add this support. Could you
please also add some link in that document to those MS api ? The patch is
complex and I think a summary document will help us to review it. We can also
use that to share the knowledge so we can understand how to add it to mac. 

Comment 23

[Shanjian Li]

Attachment: simple documentation

Comment 24

[Shanjian Li]

blizzard, would you mind give sr?

Comment 25

[Christopher Blizzard (:blizzard)]

Comment on attachment 99598 [details] [diff] [review]
proposed patch 1.0

sr=blizzard

Comment 26

[Shanjian Li]

fix checked in. 

Comment 27

[Frank Tang]

rui and kasumi:
The feature is complete, please verify this feauter work in general. If you see
some minor issue still there, please file seperate bug report for those. Please
keep this bug as the "feature is missing" bug, and let other "feature has bugs"
bug handle those issues. 

Comment 28

[Kasumi]

Flank:
Which build should I use for confirmation?

Comment 29

[Kasumi]

tested on 2002-10-01-08-trunk
Win XP JA

Not fixed but status is different than before.
Actualy, on step 5, still in convert mode. This is good.
But can't inseart any characters in there.
Try to inseart DBCS character, cursor move to the end of that line and the
moment when type a character, prior characters are committed.

Comment 30

[Shanjian Li]

I tried this on XP (simplified chinese with japanese IME), I could type
character after I moved cursor to some place in composing string. What did you see?

Comment 31

[Shanjian Li]

kasumi, would you mind try this again? I don't see any problem on my side.
Please try simplified XP with japanese IME, and make sure we are seeing the same
things. We need to find out if this is a generic problem or a problem specific
to  XP ja.

Comment 32

[Kasumi]

Which build do I need to use to match with your test?

Comment 33

[Shanjian Li]

I just downloaded mozilla trunk daily build 2002100409, and it works fine for me
on win2K (simplified chinese) with MS IME 2000(Japanese). 

Comment 34

[Kasumi]

I verified on mozilla trunk daily build 2002100409.
Win XP Pro. JA
What is correct status to change?

Comment 35

[Shanjian Li]

I will mark it fixed, then you can mark it verified. 

Comment 36

[Kasumi]

tested on 2003-01-09-08-trunk
Win 2000 JA SP3
Still occur.

Comment 37

[Frank Tang]

I think the remainning issue has nothing to do with mouse movement. I can
repordue the samethign with arrow key . close this bug. Please file a seperate
bug about inserting character during IME convert and IME commit . 

Comment 38

[Teruko Kobayashi]

Changed QA contact to myself.

Comment 39

[Teruko Kobayashi]

I created new bug 208992 for remaining issue. I close this bug.