37237 - non-NSPR functions used in plug-in wrapper code

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[rusty.lynch]

Plateform specific non-NSPR functions are used in 
mozilla/modules/plugin/nglsrc/nsPluginHostImpl.cpp's 
nsPluginCacheListener::OnStartRequest() method.

Also, streaming data is being stored in the same file name for all plug-ins
so that if two plug-ins are placed on the same page, one's data will clobber the
other's data.

A patch from [e-mail] follows...

Comment 1

[rusty.lynch]

Attachment: patch to mozilla/modules/plugin/nglsrc/nsPluginHostImp.cpp

Comment 2

[rusty.lynch]

Now that I think about it, saving data to the '/tmp' directory isn't 
going to work on Win/Mac.  Where should tmp data go in a cross platform
type of implementation?  Should we be user's prefs directory?

Comment 3

[sean echevarria]

Attachment: patch for xp tmp dir

Comment 4

[sean echevarria]

*** Bug 40657 has been marked as a duplicate of this bug. ***

Comment 5

[sean echevarria]

I'm testing a fix for the cache.  Once it goes in, all the lack of cache 
workarounds in nsPluginHostImpl.cpp will be removed and this bug will be moot.

Comment 6

[sean echevarria]

Fixed with patch checked in for http://bugzilla.mozilla.org/show_bug.cgi?
id=23667

Comment 7

[shrirang khanzode]

closing this based on Sean's comment.