37243 - unable to load URL from History window

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P1)

Description

[sairuh (rarely reading bugmail)]

found this on linux (waiting for other builds), opt comm 2000.04.26.09.

smoketest #20:
1. surf to various webpages.
2. open History window from Tasks > Tools > History.
3. double-click any URL listed to load it.

expected: the double-clicked URL should load into another web browser window.

result: it doesn't; no additional browser window opens either. get the following
console error:

JavaScript error: 
chrome://communicator/content/bookmarks/bookmarks.js line 488: getBrowserURL is
not defined

Comment 1

[sairuh (rarely reading bugmail)]

also occurs in Bookmarks win --updating component due to console error.

Comment 2

[sairuh (rarely reading bugmail)]

external smoketester is seeing this on the win32 bits, too. changing platform to
All.

Comment 3

[Radha on family leave (not reading bugmail)]

Reasign to slamm..

Comment 4

[Claudius Gayle]

The problem was not there in yesterday's build and danm checked in at the very line in question yesterday(in bookmarks.js), and 
it showed up in today verif. builds so I'm cc'ing him. Maybe the change exposed abug elsewhere?

from:
window.openDialog( "chrome://navigator/content/navigator.xul", "_blank",
  "chrome,all,dialog=no", url );

to:
window.openDialog( getBrowserURL(), "_blank", "chrome,all,dialog=no", url );

Comment 5

[leger]

Putting on [dogfood-] radar, not blocking daily work.  Adding nsbeta2 keyword, 
and Putting on [nsbeta2+] radar.

Comment 6

[Claudius Gayle]

*** Bug 37112 has been marked as a duplicate of this bug. ***

Comment 7

[Steve Lamm]

*** Bug 38807 has been marked as a duplicate of this bug. ***

Comment 8

[Claudius Gayle]

this started, kindof working with yesterday's (2000050909) builds for Bookmarks but still nothing for history. I wrote bug 38813 

for the new bookmarks wierdness.

Comment 9

[don]

M16.

Comment 10

[Cyril Bortolato]

*** Bug 39302 has been marked as a duplicate of this bug. ***

Comment 11

[Steve Lamm]

I just checked in a fix for the history window.

Comment 12

[Claudius Gayle]

VERIFIED Fixed for 2000052310 builds

Comment 13

[shrirang khanzode]

reopening. Cannot load url's from HISTORY (2000060508). OS=ALL

Comment 14

[shrirang khanzode]

changed summary

Comment 15

[don]

Yep, this is broken again in today's build.  Dang.

Added "rjc" to status whiteboard to indicate that this is a bug that Robert
Churchill will handle while slamm is on sabbatical.

Comment 16

[Steve Lamm]

I just checked in a fix.

Comment 17

[Claudius Gayle]

VERIFIED Fixed with 2000060709 builds

Comment 18

[sairuh (rarely reading bugmail)]

is this fixed in the trunk [m17]? this is still a problem in the branch [m16],
so reopening. however, if it's really fixed in the trunk, feel free to resolve
it [again ;-)].

Comment 19

[sairuh (rarely reading bugmail)]

well, looks like this works on the trunk bits...

Comment 20

[Robert John Churchill]

Marking FIXED (don't care about the M16 branch).

Comment 21

[Asa Dotzler [:asa]]

I'm seeing this again with Mac mozilla bits from 062308 and win32 mozilla build 
from 062308.  reopening.

Comment 22

[Robert John Churchill]

This is working fine for me on all platforms with current builds of the tip from 
today.  Marking FIXED.

Comment 23

[Claudius Gayle]

VERIFIED Fixed with 2000062808 builds on all platforms

Comment 24

[Justin Wood (:Callek)]

such an old bug, please file a new one if there are any current issues. (clearing flags).

Failing that, please use landfill to test bugzilla and not old bugs like this.