Closed Bug 37272 Opened 25 years ago Closed 25 years ago

macsockotpt.c: inet_addr() should return -1 rather than assert on failure

Categories

(NSPR :: NSPR, defect, P3)

PowerPC
Mac System 8.6
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Right now the Mac implementation of inet_addr() (defined in mozilla/nsprpub/pr/src/md/mac/macsockotpt.c) asserts if OTInetStringToHost() fails. This is bad. It should return -1.
Attached patch Proposed patch.Splinter Review
Checked in the fix on the main trunk. /cvsroot/mozilla/nsprpub/pr/src/md/mac/macsockotpt.c, revision 3.17 Checked in the fix on the NSPRPUB_RELEASE_4_0_BRANCH /cvsroot/mozilla/nsprpub/pr/src/md/mac/macsockotpt.c, revision 3.14.8.5 Checked in the fix on the NSPRPUB_CLIENT_BRANCH /cvsroot/mozilla/nsprpub/pr/src/md/mac/macsockotpt.c, revision 3.15.2.3
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.0.1
Target Milestone: 4.0.1 → 4.0.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: