37470 - Implement CSSStyleRuleImpl::GetParentRule()

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P2)

Description

[Johnny Stenback (:jst)]

Pierre, does the style system know about parent rules, for instance

@media {
  foo {
    clolr: red;
  }
}

Does the stylesystem know that the media rule is the parent of the foo rule?

Comment 1

[Pierre Saslawsky]

Closed as Invalid. The 'AtRules' are not parent rules.
The style system knows the medium attached to the stylesheet the rule belongs to 
(look for UseForMedium()).

Comment 2

[Johnny Stenback (:jst)]

Ok, cool, I'll just make the DOM accessors for this throw the exception
NOT_SUPPORTED_ERR and that should be ok, thanks for checking. Verified invalid.

Comment 3

[Pierre Saslawsky]

I guess I did not understand what you were looking for. Re-opening.

Comment 4

[Johnny Stenback (:jst)]

Ok, I'm sorry, I should have been more clear here, to give a useage sample with
the above css (and using color and not clolr:)

Say you have CSSStyleRule variable "a" for the "foo" rule and we call (in JS)

	var fooParent = a.parentRule;

Can we easily return (the DOM CSS version) for the native CSSMediaRuleImpl?

I've got the DOM CSS version of CSSMediaRuleImpl in my tree, still needs some
cleaning up...

Please note tho that this is not a very important feature but if it's easy to
do we might as well do it.

Comment 5

[ekrock's old account (dead)]

Johnny, I'm not totally sure whether the Description here refers to 
GetParentRule() or CSSMediaRuleImpl. Regardless, at this point, please push off 
to FUTURE all bugs/features that are not absolutely critical for providing a 
solid web app platform, regardless of how easy they may be. Got to close down 
development and focus on fixing ASAP.

Comment 6

[Johnny Stenback (:jst)]

CSSMediaRule shouldn't need any modifications here (appart from some DOM
updates), CSSMediaRuleImpl just happens to be what's typically (always?)
returned by GetParentRule().

This is not at all critical for providing a solid web app platform.

Comment 7

[Pierre Saslawsky]

Pushed to Future.

Comment 8

[Hixie (not reading bugmail)]

Taking QA Contact on all open or unverified DOM Style bugs...

Comment 9

[Hixie (not reading bugmail)]

Nominating this bug for nsbeta1 on behalf of [e-mail].

Comment 10

[Hixie (not reading bugmail)]

Removing nsbeta1 nomination -- there was a misunderstanding and some "approved
out features" were nominated by mistake! Sorry!

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 12

[Boris Zbarsky [:bzbarsky]]

Taking.  reviews?

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase-like thing

Comment 14

[Pierre Saslawsky]

Comment on attachment 49545 [details] [diff] [review]
Proposed patch

r=pierre

jst, please s/r

Comment 15

[Johnny Stenback (:jst)]

Comment on attachment 49545 [details] [diff] [review]
Proposed patch

sr=jst

Comment 16

[Boris Zbarsky [:bzbarsky]]

This was checked in on 2001-09-19