Closed Bug 37712 Opened 24 years ago Closed 19 years ago

"Receiving: message headers" should be "Downloading message headers 123 of 1323"

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

Product:
SeaMonkey
Component:
MailNews: Message Display
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: tmeader)

Details

Attachments

(2 files, 2 obsolete files)

patch for the suite [checked in]
3.42 KB, patch
Bienvenu
: review+
neil
: superreview+
asa
: approval1.8b3+
Details | Diff | Splinter Review
patch for thunderbird
3.40 KB, patch
mscott
: superreview+
Details | Diff | Splinter Review 
In:
http://lxr.mozilla.org/seamonkey/source/include/allxpstr.h#7146
http://lxr.mozilla.org/seamonkey/source/include/allxpstr.h#7149

message should be capitalized so it reads:
"%s Receiving: Message headers %lu of %lu" )
and 
"%s Receiving: Message flags %lu of %lu" )
Severity: normal → minor
Hardware: PC → All
are we stil using these?
Status: NEW → ASSIGNED
Target Milestone: --- → M18
Am I correct that the files are not used anymore by Mozilla?
So is this bug invalid?

Is there a bug to remove the allxpstr.h file?
Ths text is now in:
http://lxr.mozilla.org/mozilla/source/mailnews/imap/resources/locale/en-US/imapM
sgs.properties#218
Summary: "Receiving: message headers" should be "Receiving: Message headers" → "Receiving: message headers" should be "Downloading message headers 123 of 1323"
The last URL doesn't exist...is this still an issue?
Attached patch patch - change capitalization (obsolete) — — Splinter Review 

    
  
Keywords: patch, 
          
            review

    
    

    
  
r=jag

    
    

    
  
cc'ing mscott for sr
Keywords: review → approval

    
    

    
  
sr=mscott

    
    

    
  
fix checked in, marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

    
    

    
  
Actually the subject says that the correct fix would be:
"Downloading message headers 123 of 1323"
?

    
    

    
  
this is not fixed. Something else was fixed.
The fix should have been to:
"Downloading message headers 123 of 1323"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached patch
          
          
        real fix (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  
someone please r, sr and checkin
Keywords: review

    
    

    
  
If I'm correct Henrik's patch practically reverses Mark's patch. Why all this
hassle?

<rant> This is so trivial, why does bugs like this even exist? Ack. </rant>

    
    

    
  
Nope. It went from:
"%s Receiving: message headers %lu of %lu"
to:
"%s Receiving: Message headers %lu of %lu"
and I wanted:
"%s Downloading message headers %lu of %lu"

perhaps it should even be:
"%s Downloading message header %lu of %lu"

    
    

    
  
how about Retrieving?

    
    

    
  
We are using downloading other places...

    
    

    
  
Hmm, I patched based on the first comment, not the summary... Oh well.

Fwiw, I prefer the singular  "header x of n" to "headers x of n" - Downloading
or Retrieving are equally preferable to Receiving. Change headers to header and
I'd r=

    
    

    
  
just a question before I make a new patch: What about "message flags"

so are these correct?
Downloading message header %lu of %lu
Downloading message flag %lu of %lu

    
  
Target Milestone: M18 → ---
Product: Browser → Seamonkey

    
    

    
  


  
This is about as simple as they get. Took into account original purpose of the
bug.

        Attachment #21968 -
        Attachment is obsolete: true

        Attachment #23923 -
        Attachment is obsolete: true

        Attachment #176780 -
        Flags: superreview?(mscott)

    
    

    
  


  
Analogous patch for Thunderbird, to keep them in sync.

        Attachment #176781 -
        Flags: superreview?(mscott)

    
  

        Attachment #176780 -
        Flags: review?(bienvenu)

    
  

        Attachment #176780 -
        Flags: review?(bienvenu) → review+

    
    

    
  
Comment on attachment 176780 [details] [diff] [review]
patch for the suite [checked in]

requesting superreview and hopefully checkin from bienvenu@nventure.com since I
don't think mscott's is necessary for this mailnews specific version.

        Attachment #176780 -
        Flags: superreview?(mscott) → superreview?(bienvenu)

    
    

    
  
I'm not sure I like the string change. still mulling it over for the thunderbid
patch.

    
    

    
  
Comment on attachment 176781 [details] [diff] [review]
patch for thunderbird

I changed my mind. I'm ok with this now.

        Attachment #176781 -
        Flags: superreview?(mscott) → superreview+

    
    

    
  
fix checked in.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 19 years ago
Resolution: --- → FIXED

    
    

    
  
Scott: please don't close suite bugs that aren't actually fixed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  

        Attachment #176780 -
        Flags: superreview?(bienvenu) → superreview?(neil.parkwaycc.co.uk)

    
  

        Attachment #176780 -
        Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

    
    

    
  
Comment on attachment 176780 [details] [diff] [review]
patch for the suite [checked in]

SM only, low risk

        Attachment #176780 -
        Flags: approval1.8b3?

    
  

        Attachment #176780 -
        Flags: approval1.8b3? → approval1.8b3+

    
  

        Attachment #176780 -
        Attachment description: patch for the suite → patch for the suite [checked in]

    
  
Assignee: scottputterman → tmeader
Status: REOPENED → NEW

    
  
Status: NEW → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: