38930 - clean up the makefile.win & Makefile.in under mozilla/themes & ns/themes

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

we should do this BEFORE we create a new skin based on the modern skin.

I can work on it today.

thanks to danm for the info:

danm wrote:

It's already pretty much too late, but I thought you'd like to know about a 
chrome makefile shortcut Bill Law did a while back. It makes listing all the 
chrome files in
the makefile easier. It's optional -- you've been doing it the other way, after 
all -- but you have to use at least part of this system to get the manifest.rdf 
stuff right. 

This is all in rules.m(a)k. It's a shortcut, is all. So instead of 

install:: 
  $(MAKE_INSTALL) file1 $(DIST)\bin\chrome\$(THEME)\navigator\skin 
  $(MAKE_INSTALL) file2 $(DIST)\bin\chrome\$(THEME)\navigator\skin 

clobber:: 
  $(RM) $(DIST)\bin\chrome\$(THEME)\navigator\skin\file1 
  $(RM) $(DIST)\bin\chrome\$(THEME)\navigator\skin\file2 

You can define the directories and then just list the files, maybe like 

CHROME_DIR=$(THEME) 
CHROME_SKIN_DIR=navigator\skin 
CHROME_SKIN = .\file1 .\file2 

it just turns out to be a lot easier (one bother -- you have to prepend ".\" to 
each file on the Windows makefile, while on the Unix makefile you just use the 
naked file
name). Some people are using this scheme. Most aren't. It'd be better if we all 
used one, of course. Personally, I've been gravitating toward the CHROME 
shortcuts
after all the chrome makefile diving I've been doing lately.

Comment 1

[(not reading, please use [e-mail] instead)]

update summary.

hoping to re-assign this to danm.

cc'ing hangas.

Comment 2

[Dan M]

D'oh! I'm closest to it, I guess. Individual module owners should prepare to 
share this bug with me. Not that mentioning that here will serve as any kind of 
warning to them.

Comment 3

[Peter Trudelle]

Mass-moving all M20-M30 XPToolkit bugs to Future

Comment 4

[Asa Dotzler [:asa]]

Sorry for the spam.  New QA Contact for Browser General.  Thanks for your help
Joseph (good luck with the new job) and welcome aboard Doron Rosenberg

Comment 5

[Thomas]

How is this cleanup going?

Comment 6

[Joel Nackman]

Seth - 
Does this bug still exist? (It was reported a long time ago)  
The problem you are reporting may well have been fixed already. 

Could you please download a recent nightly build from 
<http://www.mozilla.org/releases/nightly.html>, and then let us know if you 
still see this problem?

Thanks,
Joel Nackman

Comment 7

[timeless]

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fthemes&file=&filetype=match&who=danm%25netscape.com&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2000-05-13+&maxdate=2000-05-14&cvsroot=%2Fcvsroot