Closed
Bug 392840
Opened 17 years ago
Closed 17 years ago
Get rid of nsCSSScanner::Unread
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(1 file)
|
7.12 KB,
patch
|
bzbarsky
:
review+
dbaron
:
review+
bzbarsky
:
superreview+
dbaron
:
approval1.9+
|
Details | Diff | Splinter Review |
Okay, in the pursuit of some potential perf wins in nsCSSScanner, I'm doing some cleanup. Because this code is kind of difficult to review, I am going to do this very slowly. This is the first part; assuming I'm not misreading the code, this shouldn't cause any significant logic changes.
Attachment #277348 -
Flags: review?(bzbarsky)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 277348 [details] [diff] [review] Patch r+sr=bzbarsky
Attachment #277348 -
Flags: superreview+
Attachment #277348 -
Flags: review?(bzbarsky)
Attachment #277348 -
Flags: review+
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 277348 [details] [diff] [review] Patch Should be safe, and this code needs cleanup for some significant potential performance improvements.
Attachment #277348 -
Flags: approval1.9?
Comment on attachment 277348 [details] [diff] [review] Patch a1.9=dbaron (and r=dbaron, since I couldn't resist looking closely)
Attachment #277348 -
Flags: review+
Attachment #277348 -
Flags: approval1.9?
Attachment #277348 -
Flags: approval1.9+
|
|
Assignee | |
Comment 4•17 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•