Closed Bug 39389 Opened 24 years ago Closed 23 years ago

No context menus in "view source" window

Categories

(SeaMonkey :: UI Design, enhancement, P1)

Product:
SeaMonkey
Component:
UI Design
Type:
enhancement

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: mozilla, Assigned: doronr)

References

Details

(Keywords: regression, Whiteboard: se-radar)

Attachments

(3 files)

proposed patch
2.85 KB, patch
Details | Diff | Splinter Review
better patch
2.06 KB, patch
alecf
: review+
alecf
: superreview+
Details | Diff | Splinter Review
patch addressing blake's comment
1.05 KB, patch
doronr
: review+
Details | Diff | Splinter Review 
Mozilla has regressed to the lowly state of NS 4.X's view source window - with 
no way to use the mouse to copy text. I am not sure when this happened, but 
there did use to be context menus in the view source window.

Build: 2000051520
Um, this is not a Browser General bug.  Updating component.  Jerry Baker, 
please take a look at http://bugzilla.mozilla.org/describecomponents.cgi?
product=Browser (the word 'Component' links to this component description 
page).  You will find that bugs get addressed much more swiftly when they are 
assigned to the proper component and owners.  Browser General is reserved for 
issues that do not fall into one of the other components.  View Source belongs 
to XPApps.  Thanks for your help in testing Mozilla and reporting bugs.
Yeah, I looked through the entire list. I wasn't sure whether it was an XPApp 
bug because it occured in a View Source window, or if it was an XPMenus thing 
because it involves a context menu.
over to XPApps
Assignee: asadotzler → don
Component: Browser-General → XPApps
QA Contact: jelwell → sairuh
this'd be good... it'd go hand in hand with bug 26593.
Severity: normal → enhancement
Component: XP Apps → XP Apps: GUI Features
OS: Windows 2000 → All
Hardware: PC → All
over to Bill, Mr. Context Menu
Assignee: don → law
It would be cool if the context menu had 'find in source' and 'find again'. Is
that part of the spec ?

spam: adding se-radar so that a query gets this easily.
Whiteboard: se-radar
over to blake, per conversation over irc.
Assignee: law → blakeross
keyword
Keywords: regression
view source is next big priority.
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → mozilla1.0
Target Milestone: mozilla1.0 → mozilla0.9
alright, so, other than "copy" and "select all", what items do we need in a 
context menu?  Keep in mind that we will have a [limited] menubar, so we don't 
necessarily need items like Find to be in the context menu
Hummm.

  Find _Previous        [finds previous occurrence of selection]
  Find _Next            [finds next occurrence of selection]
----------------------
  _Copy
----------------------
  Select _All

That's my best guess right now. It maintains consistency of position of `Copy' 
between the context menu for View Source and the context menu for a text field 
(unfortunately we can't do the same for `Select All'); and the `Find Previous' 
and `Find Next' (which I would imagine being two of the most common activities in 
the view source window) are symmetrical with the `Back' and `Forward' in the 
context menu for a Web page.

I'd like just plain 'find' in there as well. Otherwise it can be a nightmare
finding the exact right piece of source you're interested in.
Doron, want to take this one also along with your other view source menu work?
ok, i'll tackle this, since the view source menu is done and pending review. 
The only thing really here is to write a function for the find previous.
Blocks: 74862
-> Doron
Assignee: blakeross → doronr
Status: ASSIGNED → NEW
-> 0.9.1, patch is ready, need viewsourcemenu to land first.
Target Milestone: mozilla0.9 → mozilla0.9.1
depends also on 77704, inorder to get "find previous: to work in a contextmenu
Depends on: 77704
We do need the "Find" option in the CM for view source. Find works in that
window anyway if you use Ctrl+F. Another thought, maybe we should have a word
wrap option? I'm not sure if there's a right way to do this with HTML files, but
it's worth a shot for sites with much-too-wide source code...
there is a wordwrap bug filed
Ctrl-F in the view source window does not work for me (Linux 2001042721).

What does that have to do with this bug?

Ctrl-F is the standard keyboard shortcut for "Find" in Windows. Maybe it's
different for Linux?
i believe the Find issue is covered by bug 71173. as for unix, ^F [ctrl+F] moves
forward one character at a time in textfields and textareas --methinks this
wouldn't be an issue for the view source window since it's read-only.
this is fixed with the viewsource menu patch (ctrl-f)
sorry, i'm confused --did you mean this was supposedly fixed for the same thing
as in bug 71173? [if so, it isn't with my 16:44 debug build.] or, were you
referring to a fix which hasn't been checked in yet [well, post 16:44 :) ]? tia!
i think so, if not, it will be fixed with the viewsource menu ui, as it works
locally ;)
oh, heh --i might be running into bug 78725 in my 5/8 verif build and bug 79720
in my debug build from y'day...
->1.0, depends on when 77704 goes in
Target Milestone: mozilla0.9.1 → mozilla1.0
Depends on: 63026
accepting
Status: NEW → ASSIGNED
*** Bug 101062 has been marked as a duplicate of this bug. ***
doron, I thought you had this working....
Attached patch proposed patch — — Splinter Review 

    
    

    
  

      
      
      
      

        Attached patch
          
          
        better  patch
        — 
          — Splinter Review
      

    


  

    
    

    
  
r=bzbarsky.  Nice.

    
    

    
  
cc: alecf for sr= check.

the "find next" to viewsource.dtd will be removed when my find next/find
previous patch lands.

    
    

    
  
Comment on attachment 50552 [details] [diff] [review]
better  patch

sure, why not. sr=alecf

        Attachment #50552 -
        Flags: superreview+

        Attachment #50552 -
        Flags: review+

    
    

    
  
Those observes="*" should be command="*"

    
    

    
  
Comment on attachment 50950 [details] [diff] [review]
patch addressing blake's comment

my bad, r=doron

        Attachment #50950 -
        Flags: review+

    
    

    
  
checked in with sr=blake on irc
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
vrfy'd fixed using 2001.11.08.0x-comm bits on linux rh6.2, winnt and mac os 10.1.

the context menu in View Source contains three items:

Find Next
Copy
Select All
Status: RESOLVED → VERIFIED

    
    

    
  
Mass removing self from CC list.

    
    

    
  
Now I feel sumb because I have to add back. Sorry for the spam.
Product: Core → Mozilla Application Suite

    
  
Component: XP Apps: GUI Features → UI Design

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: