394752 - Caret stands still when moving with the arrow key between lines in a pre block

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, to reproduce the bug:
To reproduce:
- Turn caret browsing on
- Move the caret in 'aaaa' and press the arrow right key to go to 'bbbb'
- You should not 'stand still' with the caret when moving to the new line in 'bbbb'

When the caret is just after 'aaaa', but still on the 'aaaa' line, pressing the right arrow key doesn't move it to the next line, you need to press the right arrow key a second time for that.

This regressed between 2007-06-20 and 2007-06-21, so I guess a regression from bug 367177, somehow.

Comment 1

[Martijn Wargers (dead)]

Still happens in current trunk build.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'd like to land the fix in bug 336408 before working on this.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

We just need to skip over preformatted newlines. As indicated in the testcase, our caret code will put the caret at the end of the first line by positioning it at the start of the second line and setting HINTLEFT to indicate that the caret is associated with the content before its position.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 5

[Martijn Wargers (dead)]

Verified fixed, using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007111605 Minefield/3.0b2pre