Closed Bug 39633 Opened 24 years ago Closed 24 years ago

Quit from browser or composer doesn't prompt to save Composer

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Brade, Assigned: bryner)

References

Details

(Whiteboard: [dogfood-] [nsbeta2+]) 

I noticed a few days ago that if I chose Quit (such as from the File menu), then 
I wouldn't be prompted to save modified files in Composer.  This causes a loss of 
data!

Note: it doesn't matter if Composer is the front window or not.

To reproduce:
 * Launch
 * New Blank Page
 * type some text
 * choose Quit from the File menu
assigning to sfraser for debug
Assignee: beppe → sfraser
Keywords: dogfood
Priority: P3 → P1
Target Milestone: --- → M16
Wow. cc danm.
Status: NEW → ASSIGNED
Over to danm. Our 'onclose' method is never being called.
Assignee: sfraser → danm
Status: ASSIGNED → NEW
domWindow.tryToClose is 'undefined' where it should not be.

[dogfood-] [nsbeta2+]
Keywords: nsbeta2
Whiteboard: [dogfood-] [nsbeta2+]
Blocks: 40158
Target Milestone: M16 → M18
reassigning to saari
Assignee: danm → saari
chris: I've found that changing the JS function goQuitApplication() in 
globalOverlay.js to call domWindow.onclose() instead of .tryToClose() works 
pretty well, and avoids having another 'special' function.

Simon, I just tried that and it doesn't seem to help
Status: NEW → ASSIGNED
I have a fix here, I think.
Assignee: saari → bryner
Status: ASSIGNED → NEW
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
this is not fixed in 6/15 build.....
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
actually this is fixed...forgot I had to make the file "dirty" first....
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified in 6/15 build.
Status: RESOLVED → VERIFIED
Reopening bug.  I am seeing this again.
I think it only happens in one of these two situations
 * modified Composer window is the front-most window
 * modified Composer window is behind a browser window
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Brian discovered it was caused by the window mediator's enumerators skipping a 
window when windows were deleted underneath them. I've made it stop doing that.
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
verified in 7/18 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.