39790 - [L12y] Move all localizable prefs into chrome://

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[tao]

This is a follow-up action of bug 33668 [nsbeta2]. Alec had checked in a new
pref API to read localizable prefs via stringbundle. 

The remaining work is to moving the real values to *.properties. I'll come
up w/ the patch and get module owners to review them.


This is a PR2 task 

The current list is:


mailnews.js:


 pref("general.useragent.locale", "en-US");     -->"ja-JP" for Ja build 
  pref("intl.accept_languages", "en");  -->"ja-JP"    -->what else? 
  intl.charset.default --> ? 
  pref("intl.charset_menu.static","iso-2022-jp, shift_jis,euc-jp,iso-8859-1");
  pref("intl.charset.detector","japsm"); 
  pref("intl.charset_menu.cache", ""); ->? 
  pref("mailnews.send_default_charset","iso-2022-jp");  -- send charset for
          Japanese 
  pref("mailnews.view_default_charset","iso-2022-jp");  -- msg view chraset
          default for Japanese 
  intl.font_charset 


pref("ldap_1.directory1.description", "Personal Address Book");
pref("ldap_1.directory6.searchBase", "c=US");
pref("ldap_1.directory6.attributes.telephoneNumber", "Phone Number:homephone");
pref("ldap_1.directory6.attributes.street", "State:st");
pref("ldap_2.servers.pab.description",  "Personal Address Book");
pref("ldap_2.servers.history.description",      "Collected Addresses");
pref("ldap_2.servers.netcenter.description",    "Netcenter Member Directory");
pref("ldap_2.servers.netcenter.customDisplayUrl",               
"http://dirsearch.netscape.com/cgi-bin/member_lookup.cgi?dn=%s");


AND


aim.js:51:pref("aim.throbber.url","http://home.netscape.com"); 
all-ns.js:2:pref("browser.startup.homepage",           
"http://home.netscape.com/"); 
all-ns.js:7:pref("browser.throbber.url","http://home.netscape.com"); 
all-ns.js:12:pref("timebomb.timebombURL",
"http://home.netscape.com/download/prredirect.html"); 
all-ns.js:16:pref("browser.registration.url",
"http://activation.netscape.com/activation/en/activation.cgi"); 
all-ns.js:17:pref("browser.registration.domain",
"http://www.netscape.com/activation/en"); 
all.js:6: * the License at http://www.mozilla.org/NPL/ 
all.js:26:pref("network.search.url","http://cgi.netscape.com/cgi-bin/url_search.cgi?search="); 
all.js:28:pref("keyword.URL", "http://keyword.netscape.com/keyword/"); 
all.js:54:pref("browser.startup.homepage",    "http://www.mozilla.org/"); 
all.js:104:pref("browser.search.defaulturl",
"http://info.netscape.com/fwd/sidb1dnet/http://search.netscape.com/cgi-bin/search?search="); 
all.js:154:pref("browser.related.provider", "http://www-rl.netscape.com/wtgn?"); 
all.js:155:pref("browser.related.detailsProvider",
"http://cgi.netscape.com/cgi-bin/rlcgi.cgi?URL="); 
all.js:251:pref("wallet.Server",                      
"http://www.mozilla.org/wallet/tables/"); 
all.js:512:pref("browser.throbber.url","http://www.mozilla.org"); 
config-ns.js:1:config("startup.homepage_override_url","http://home.netscape.com/browsers/redirect/6/start.html"); 
config.js:26:config("startup.homepage_override_url","http://www.mozilla.org/mozorg.html"); 

editor-ns.js:1:pref("editor.throbber.url","http://home.netscape.com"); 
mailnews-ns.js:2:pref("mailnews.start_page.url",
"http://messenger.netscape.com/bookmark/4_7/messengerstart.html"); 
mailnews-ns.js:3:pref("messenger.throbber.url","http://home.netscape.com"); 
mailnews-ns.js:4:pref("compose.throbber.url","http://home.netscape.com"); 
mailnews-ns.js:5:pref("addressbook.throbber.url","http://home.netscape.com"); 
mailnews.js:309:pref("ldap_2.servers.netcenter.customDisplayUrl",   
"http://dirsearch.netscape.com/cgi-bin/member_lookup.cgi?dn=%s"); 
mailnews.js:352:pref("mailnews.start_page.url",
"http://www.mozilla.org/mailnews/start.html"); 
mailnews.js:390:pref("mail.display_glyph",true);   // see
<http://www.bucksch.org/1/projects/mozilla/16507/> 
mailnews.js:398:pref("messenger.throbber.url","http://www.mozilla.org"); 
mailnews.js:399:pref("compose.throbber.url","http://www.mozilla.org"); 
mailnews.js:400:pref("addressbook.throbber.url","http://www.mozilla.org");

Comment 1

[tao]

This is not a new bug; its a continuation of bug 33668. The feature work had
been checked in already.

Comment 2

[leger]

Setting to [NEED INFO] radar for PDT feature review tomorrow night.

Comment 3

[tao]

Currently, all the localizable pref values such as user agent string and 
accept-languages (see more in the description field) are still in
bin/defaults/pref/*.js. 

The final decision of making them accessible via locale-specific path (such 
as chrome URLS) is to implement a new type of Pref API to retrieve them from
within properties files. The implementation had been checked in into the tree;
however, we are not calling this new API to retrieve localizable prefs yet.

We need to fix this bug in order to carry out the CountryPicker plan. Otherwise,
we won't be able to create locale-sensitive user profile.

Comment 4

[tao]

info provided

Comment 5

[tao]

m16

Comment 6

[leger]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 7

[tao]

I am working on

  #all.js
  browser.startup.homepage
  browser.throbber.url
  #config.js
  startup.homepage_override_url

Comment 8

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 9

[Frank Tang]

tao, please update the status of this bug. ETA ?

Comment 10

[tao]

OK, five left:

  intl.accept_charsets
  intl.charsetmenu.browser.static
  send_default_charset 
  view_default_charset
  intl.charsetmenu.mailedit


Frank had kindly offered to help. I am moving to other tasks.

Comment 11

[leger]

Putting on [7/18] for fix by end of that day.

Comment 12

[Frank Tang]

The fix for 
intl.charsetmenu.browser.static
intl.charsetmenu.mailedit

could be found at http://warp/u/ftang/tmp/charsetmenudiff.txt
tao, please review it.

Comment 13

[tao]

looks good!

thanks

Comment 14

[Frank Tang]

It is very very hard to change this for 
  send_default_charset and   view_default_charset
we need to change the following file (which should be easy)
modules/libpref/src/init/mailnews.js
mailnews/base/util/nsMsgDBFolder.cpp
mailnews/base/util/nsMsgI18N.cpp
mailnews/compose/prefs/resources/content/pref-messages.js
mailnews/mime/src/mimetext.cpp
mailnews/compose/resources/content/MsgComposeCommands.js

However, because the following files are using some general pref utility to read 
the pref. We many need to change 
xpfe/components/prefwindow/resources/content/pref.js,nsPrefWin.js 
mailnews/base/prefs/resources/content/pref-viewing_messages.xul
mailnews/compose/prefs/resources/content/pref-composing_messages.xul

Comment 15

[tao]

Hi, Frank:


Regarding the pref access in Pref dialog, Ben is adding a new preftype which
use will call getLocalizedUnicharPref()/SetUnicharPref() to get/set such prefs.

After his checkin, we simply change the preftype in Pref dialog's xul files
and fix them all.

He estimated a few hours of work last week; haven't seen him checkin the fix,
though. I haven't managed to get hold of him this week. Perhaps, we should ping
him again.

Comment 16

[Frank Tang]

I don't think we need to change "intl.accept_charsets"
This pref have not be used by the product YET.

OK, here is my fix for the mailnews.send_default_charset and 
mailnews.view_default_charset without ben's fix. I put some hack in 
nsPrefWindow.js untill ben add that support.
tao- please review the code. I won't check in tonight. I need more testing 
before check in.
The fix can be found at http://warp/u/ftang/tmp/mailnewsdiff.txt

Comment 17

[Frank Tang]

I will check in http://warp/u/ftang/tmp/charsetmenudiff.txt tonight

Comment 18

[tao]

Hi, Frank:

Since I am not able to get hold of Ben, I'd like to reuse your hack in 
pref-*.xul so the default prefs will at least show in Pref dialog. We will let
Ben replace the hacky code with the right implementation, then.

I'll do that after your checkin if I am not able to catch you. I'll will also
attach the patch here.


Thanks

Comment 19

[Frank Tang]

I fix all I asked to do. Reassign to tao. Should we close this one.

Comment 20

[tao]

Attachment: Hacky code to call getLocalizedUni...() for special pref.

Comment 21

[tao]

Hi, Ben:


Since I am not able to reach you for days, I took the liberty to
use the hacky code to prevent Pref dialog from getting wrong default
prefs values. Please replace them with proper implementation.

Reassign to Ben to add a new preftype which call getLocalizedUnicharPref()
to retrieve localizable prefs from property files.


Thanks

Comment 22

[don]

Tao,

You can't reach Ben because he's been away at the O'reilly conference and will
remain until Friday.  Please come and explain to me why he has this bug (which
looks like a new feature to me) and why he needs to fix this for beta 2.  I will
then decide who should fix it, but I really don't see why this bug is a beta 2
blocker.

Comment 23

[don]

Re-assign to tao.

Comment 24

[Phil Peterson]

Since the hacky fix is checked in, I don't think this is a beta2 stopper
anymore, so marking nsbeta2-.

Comment 25

[tao]

We have done all we could. Moving the rest of the pref will need a separate bug.

Comment 26

[Teruko Kobayashi]

Verified.