39942 - PR_SetError calls free.

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Wan-Teh Chang]

PR_SetError always deletes the calling
thread's errorString buffer.  This may
result in excessive calls to free.
The errorString buffer should be kept
around for possible reuse.  PR_SetError
just needs to mark the errorString buffer
empty.

Comment 1

[Wan-Teh Chang]

Reassigned to larryh.

Comment 2

[larryh (gone)]

Attachment: Proposed fix, with test case

Comment 3

[larryh (gone)]

Checked in parts:

Checking in pr/include/private/primpl.h;
/cvsroot/mozilla/nsprpub/pr/include/private/primpl.h,v  <--  primpl.h
new revision: 3.48; previous revision: 3.47
done

Checking in pr/src/misc/prerror.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prerror.c,v  <--  prerror.c
new revision: 3.7; previous revision: 3.6
done

Checking in pr/tests/Makefile;
/cvsroot/mozilla/nsprpub/pr/tests/Makefile,v  <--  Makefile
new revision: 3.62; previous revision: 3.61
done

RCS file: /cvsroot/mozilla/nsprpub/pr/tests/errset.c,v
done
Checking in pr/tests/errset.c;
/cvsroot/mozilla/nsprpub/pr/tests/errset.c,v  <--  errset.c
initial revision: 1.1
done

Comment 4

[Wan-Teh Chang]

Larry, I reviewed your checkin.  I like it that
you are defining errorStringSize and errorStringLength
as buffer size and string length, respectively.  The
original code defined errorStringSize as "buffer size - 1"
(i.e., the string length), which was really confusing.

I found two minor problems.  One is that we need to
set errorStringLength to 0 whenever we set errorStringSize
to 0.  The other is that in PR_GetErrorText(), errorStringSize
needs to be changed to errorStringLength.  I will attach
a patch.

Comment 5

[Wan-Teh Chang]

Attachment: Additional fixes.

Comment 6

[larryh (gone)]

marking as fixed.

Comment 7

[Wan-Teh Chang]

I checked in my additional fixes (attachment id=10559).
/cvsroot/mozilla/nsprpub/pr/src/misc/prerror.c, revision: 3.8
/cvsroot/mozilla/nsprpub/pr/src/threads/prcthr.c, revision: 3.17
/cvsroot/mozilla/nsprpub/pr/src/threads/combined/pruthr.c, revision: 3.29