399478 - Accessing the GMail Inbox page While Window-eyes is Running Crashes Firefox

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Tim Keenan]

1. Launch Window-eyes
2. Open gmail.com and log in.

Window-eyes will load the resulting page into its buffer but immediately crash.  Here's the url to a rellevant crash report:
http://crash-stats.mozilla.com/report/index/c8ea64c5-7762-11dc-a2fb-001a4bd43ef6?date=2007-10-10-18

I'm working on a regression range, but initially this seems to go back quite a ways into the alpha cycle.

I notified GW Micro regarding this bug.  Maybe we can put our heads together and figure out what's happening.

Comment 1

[Tim Keenan]

08-14-09 works, 08-15-05 crashes.

Comment 2

[Tim Keenan]

I'm not sure if this is related to bug 390670 or not.  Testing immediately after the fix for bug 387347 fixed bug 390670 confirmed that it was fixed.  That testing was done on 08-12.  

Comment 3

[Aaron Leventhal]

Tim, does it still crash for you?

Comment 4

[Aaron Leventhal]

Attachment: Missing null check on the line for the crash (from the crash report)

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 286317 [details] [diff] [review]
Missing null check on the line for the crash (from the crash report)


>+  nsIDocument *doc = content->GetDocument();
>+  NS_ENSURE_TRUE(doc, NS_ERROR_FAILURE);
>+

GetDocument() is deprecated, use GetCurrentDoc() instead. Would you like to add an assertion, is it ok there is no document for node?

Comment 6

[Aaron Leventhal]

I'll add an assertion, since I don't understand exactly when that would happen.

Comment 7

[Tim Keenan]

Verified fixed.