401735 - "Permission denied to create wrapper" exceptions not logged when raised in event handler

Status: RESOLVED FIXED

(Core :: XPConnect, defect, P2)

Description

[Steve Krulewitz]

Attachment: test page

This is likely a regression from bug 393627.  STR:

1. Open attached test file in Firefox 2.0 and open the error console
2. Click "Call function", note that an error is logged ("Error: uncaught exception: Permission denied...")
3. Click "Dispatch event", note that en error is logged ("Error: [Exception... "'Permission denied...")
4. Open attched test file in a trunk build and open the error console
5. Click "Call function", note that an error is logged
6. Click "Dispatch event", note that an error IS NOT logged

So the script is silently failing when it throws a permission denied exception.  

This is a bit more problematic for Songbird since we have a "songbird" web page object with lots of security settings and it is difficult to debug security related problems when the errors are not logged.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Oops, I missed one or two! I went back through and these really are the only non-nsresult-thrown error codes possible.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 287614 [details] [diff] [review]
Proposed fix

Super-safe fix to ensure that we report thrown exceptions.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 287614 [details] [diff] [review]
Proposed fix

Feel free to land this once the tree opens up for post-beta1 checkins.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Fix finally checked in.