40177 - Enable OS/2 Build

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Huynh Trinh]

Changes to enable OS/2 build. 

Previous OS/2 build changes (which are numerous) are in bugzilla 34106 
and Chris has been very helpful cheking in the changes for us. Since 
he will be away for a while, it is convenient point in time and place 
to break away from the previous bugzilla and start a fresh one with 
[e-mail] to be our main contact. Hopefully it will less 
confusing also.

Comment 1

[Huynh Trinh]

Attachment: Batch01 - Fix a typo and rules.mk for OS/2

Comment 2

[Huynh Trinh]

Attachment: Batch02 - Fix mailnew/absync.build/makefile.in

Comment 3

[Huynh Trinh]

Attachment: Batch03 - add SHORT_LIBNAME to 2 xpfe\components makefiles

Comment 4

[snizinsk]

Chris,
If you're back from vacation can you take a look at these. Many of them are 
trivial changes. We'd really like to get these in by the time M16 comes out. 
Thanks.

Comment 5

[snizinsk]

Attachment: batch 04 new rules.mk (supercedes batch01) for VisualAge

Comment 6

[snizinsk]

Additional note on Batch04 attachment:
This rules.mk file has one additional change above the one submitted in Batch01. 
All of the changes are isolated to ifeq ($(MOZ_OS@_TOOLS),VACPP)) ifdefs. 

Comment 7

[snizinsk]

Attachment: Batch 05 js/src/Makefile.in change tab char in VACPP section

Comment 8

[Daniel (Leaf) Nunes]

Damn, i thought i commented on this bug that the changes looked fine... i'll
re-review them and comment again.

Comment 9

[Daniel (Leaf) Nunes]

Yeah, looks fine. When the tree starts taking changes again today, r,a=leaf

Comment 10

[snizinsk]

Leaf,
Are all of the changes (batch01 thru batch05) ok to check in? Thanks.

Comment 11

[Daniel (Leaf) Nunes]

yes, i reviewed each batch... when the tree starts taking changes again
(probably within the next 1.75 hours, keep an eye on the top of tinderbox), you
are free to checkin with a,r=leaf

Comment 12

[snizinsk]

thanks.

Comment 13

[Huynh Trinh]

Attachment: Batch06 - modules/libpref/.. and security/psm/.. Makefile.in

Comment 14

[Daniel (Leaf) Nunes]

can you explain the libpref/src/Makefile.in changes to me, i'm not sure i
understand why you're getting rid of some of the includes.

Comment 15

[sobotka]

Leaf, what do you mean by the "includes"?

Also, MOZ_COMPONENT_LIBS has to come before MOZ_JS_LIBS, or else that diff can 
safely be ignored.

Comment 16

[Huynh Trinh]

Attachment: Batch07 - Corrections to Batch 06 modules/libpref/.. Makefile

Comment 17

[Daniel (Leaf) Nunes]

Ok, i didn't see the + MOZ_COMPONENT_LIBS there, batch 7, r=leaf

Comment 18

[snizinsk]

Leaf,
How about the security/psm diff in batch 06? Thanks.

Comment 19

[snizinsk]

Attachment: Batch08 widget\timer\public\Makefile.in export nsITimerQueue.h

Comment 20

[snizinsk]

Leaf and/or Chris,
Would you please review the security/psm/lib/client/Makefile.in change in batch 
6 and also the widget/timer/public/Makefile.in change in batch 8? Thanks.

Comment 21

[Huynh Trinh]

Attachment: Batch09 Add os2 directories to allmakefiles.sh

Comment 22

[Daniel (Leaf) Nunes]

I'd really like someone familiar with timer code to do a review as well...  but
to me, your changes look ok. Chris? Are you back?

Comment 23

[cls]

I suppose I am.  Batch 9, r=cls. Batch 8, r=cls unless Pavlov knows why that
interface shouldn't be used. The security/psm changes in batch 6 look fine as
well although I don't understand the need to switch from $(DIST)/bin to
$(DIST)/lib unless that library is static.  

Leaf, do you know who's the proper contact to get these security changes (and
others) into both the SECURITY_CLIENT_BRANCH and their tip?

Comment 24

[sobotka]

On OS/2, compiletime linkage is against the import libraries in /lib (each DLL 
has a corresponding .lib for linkage); /bin is irrelevant to us at that stage. 
Runtime linkage is with the DLLs in /bin, and that's controlled by a LIBPATH 
environment setting.

Comment 25

[Huynh Trinh]

Attachment: Batch10 - Fix typo in nsDnsService.cpp for OS/2

Comment 26

[snizinsk]

Gagan has approved the change to nsDNSService.cpp (batch 10) and we are going to 
check it in.

Comment 27

[Huynh Trinh]

Attachment: Batch11 - Update configure.in & security/psm/lib... makefile

Comment 28

[sobotka]

Huyhn, the security Makefile.in change will break VAC++. Better to use

EXTRA_DSO_LIBS = protocol

as elsewhere and let the macro in rules.mk handle the conversion.

Comment 29

[snizinsk]

Attachment: batch12 - rules.mk VisualAge change

Comment 30

[cls]

r=cls on Batches 11 & 12

Comment 31

[snizinsk]

Chris,
Would you mind checking in the 3 files in batches 11 & 12? We particularly 
aren't sure about what to do about the security/psm file. Please advise. Thanks.

Comment 32

[snizinsk]

Attachment: Batch13 - configure.in, config.guess, config.sub

Comment 33

[snizinsk]

Leaf and/or Chris,
Please review the changes in batch13. Thanks.

Comment 34

[cls]

You may want to submit your changes to config.guess & config.sub to the
maintainer of the autoconf maintainers, [e-mail].  We will periodically
be syncing against their updates and it'll save us the trouble of having to
merge the updates separately.

r=cls on Batch 13

Comment 35

[Huynh Trinh]

Attachment: Batch14 - Add back MOZ_TIMER_LIBS for OS2

Comment 36

[Huynh Trinh]

Attachment: Batch15 - Correction to AUTOCONF.MK.IN in batch 14

Comment 37

[Daniel (Leaf) Nunes]

Are these for the branch?

Comment 38

[Huynh Trinh]

Batch14 and the correction in Batch15 are intended for both branch & 
tip
 

Comment 39

[Daniel (Leaf) Nunes]

Ok, we missed the branch cut off date, so these will have to go into just the
trunk; if necessary for the release build for m16, we'll have to include a
patchfile with the source indicating it's necessity for OS/2.

r=leaf for batches 14,15

Comment 40

[snizinsk]

Attachment: Batch16 - rules.mk and extensions/psm-glue/res/content/Makefile.in

Comment 41

[snizinsk]

Leaf, Chris,
Would one of you review the batch16 changes for us? Thanks.
Skip 

Comment 42

[snizinsk]

Attachment: Batch17 config.mk changes

Comment 43

[snizinsk]

Leaf, Chris,
We are FINALLY getting real close to having an OS/2 Tinderbox build. Please 
review the batch16 and batch17 changes for us. Thanks for your help.
Skip

Comment 44

[Mike Kaply [:mkaply]]

Attachment: New rules.mk diff

Comment 45

[Mike Kaply [:mkaply]]

Attachment: New diffs for config/Makefile.in and rules.mk

Comment 46

[cls]

r=cls on the latest config & rules.mk patch

Comment 47

[snizinsk]

Attachment: uriloader/exthandler/Makefile.in

Comment 48

[cls]

r=cls on uriloader change

Comment 49

[snizinsk]

Attachment: remove gfx\src\ps from OS/2 build (Makefile.in)

Comment 50

[cls]

r=cls on gfx change.

Comment 51

[sobotka]

Attachment: Patch for enabling MNG support

Comment 52

[Mike Kaply [:mkaply]]

Attachment: EMX change needed in configure.in

Comment 53

[cls]

r=cls on mng change & emx configure.in change

Comment 54

[sobotka]

Mike, with that configure. in change we should remove it from the OS/2 Build 
Options block around line 3400. In fact, we could also set MOZ_OS2_TOOLS 
(needed for NSPR OS2.mk) automatically in the *-*-os2* block and scrap the OS/2 
configure --with options altogether.

Comment 55

[Mike Kaply [:mkaply]]

Attachment: Fix for tinderbox break - Need JS libs

Comment 56

[Mike Kaply [:mkaply]]

Attachment: Change to rules.mk for OS/2 - substitution in LIBS and EXTRA_DSO_LIBS macros

Comment 57

[Mike Kaply [:mkaply]]

Attachment: webshell/tests/viewer/Makefile.in changes for Os/2

Comment 58

[Mike Kaply [:mkaply]]

Attachment: Rules.mk change to delete OS/2 specific files on the clobber

Comment 59

[cls]

The last 4 patches look good to me. r=cls (back to vacation)

Comment 60

[cls]

Are we done here?

Comment 61

[Mike Kaply [:mkaply]]

We're done with this one.

Comment 62

[Jon Granrose]

If anyone should know this bug is done, it's mkaply.

marking verified.