40360 - Filter UI: Filter rules dialog missing New Folder button/functionality.

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P2)

Description

[laurel]

Using may23 m16 commercial build

The filter rules dialog is missing the New Folder button in its Action section.
The button should appear enabled only when Move To Folder is selected in the
action field.  When Action is set to some other value, we should disable the
button (this is what 4.x does).

Comment 1

[laurel]

Oh, and, when user engages the enable New Folder button we should launch to New
Folder dialog and underlying functionality.  If user creates a new folder
through this dialog it should immediately appear in the list of available
selections for the Move to Folder destinations.

Comment 2

[Alec Flett]

doh! fix is easy.

Comment 3

[Alec Flett]

fixed.

Comment 4

[laurel]

This isn't in jun7 m17 builds... will check again in a later build.

Comment 5

[Alec Flett]

wow, I have NO idea why I marked this fixed.
I must have though it was another bug.

Comment 6

[scottputterman]

mass moving to M18 and adding nsbeta3 keyword

Comment 7

[laurel]

cc jglick for possible note in spec.

Comment 8

[Alec Flett]

reassigning my filter bugs to gayatrib..

Comment 9

[laurel]

Related problem if this is implemented: new folders don't appear in menus, see
bug 57257 .

Comment 10

[scottputterman]

marking nsbeta1+ and moving to mozilla0.9

Comment 11

[scottputterman]

moving to mozilla0.9

Comment 12

[gayatrib]

fix in hand. will post patch soon.

Comment 13

[gayatrib]

Fix in hand. Attaching patch. Adding patch, review keywords. Adding racham for 
review and bienvenu for sr.

Comment 14

[gayatrib]

Attachment: patch

Comment 15

[gayatrib]

The patch does the following:
1) Add New Folder button to the filter editor dialog--so a person can create new 
subfolders in a folder while creating/editing filters.
2) As I attempt to use the already existing functionality provided by 
MsgNewFolder and CreateNewSubfolder methods... but run into scope resolution 
problems as I attempt to call a different callback function on "ok" in the new 
folder dialog, I modified these functions to take the callBackFunction to be 
called as a parameter--instead of using it the hard coded way it is now.
3)So i modify all the calls to these functions too.

Patch has been well tested.
Bhuvan, could you please take a look and review it?
David, can I get a sr?

Comment 16

[David :Bienvenu]

you should add the newlines at the ends of those files to get rid of that diff
warning. Also, cc'ing Seth about the passing of a callback function name - is
that the right way of doing things? If it's OK with Seth, it's OK with me.

Comment 17

[gayatrib]

thanks david. I will add the newlines. Jean-Francois suggested to me to pass the 
name of the callback function to resolve the scope resolution. Adding him also 
to the cc list.

Comment 18

[(not reading, please use [e-mail] instead)]

yes, it is ok to use the function name like that for the callback.
what happens in the case where the new folder creation fails?
(say a folder with that name already exists)
is the error handled properly?

Comment 19

[gayatrib]

Error handling is done properly. The New Folder dialog takes care of that error 
handling part. So when i try to create a folder with the same name, it comes 
back saying that mailbox already exists. etc.

Can I get an r/sr on this?

Comment 20

[David :Bienvenu]

sr=bienvenu

Comment 21

[gayatrib]

r=racham

Comment 22

[gayatrib]

review done (by me) at gayatrib's desk. sorry for the confusion.

-racham

Comment 23

[gayatrib]

fix checked in.

Comment 24

[laurel]

Button present and functional.
Any specific issues with new folder button functionality in filters will be
logged separately.

OK using feb26 commercial trunk builds: linux rh6.0, mac OS 9.0, win98