4051 - [PP]Increasing allocated memory to >35 MB crashes on launch

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P1)

Description

[cpratt]

Using the March 19 build, if you set the app's memory Preferred Size to 35000 K,
the app launches fine. Set it to 36000 K and the app quits at launch. (This is
using Mac OS 8.5.1 on a Rev A iMac.)

Comment 1

[cpratt]

The magic numbers: 35192 - works, 35193 - crashes (as per [e-mail])

Comment 2

[cpratt]

Claudius now says that although those numbers were valid for the 15 March
build, they do not appear to be valid for the 19 March build. He's currently
investigating this.

Comment 3

[leger]

Clearing Milestone for don to re-set.

Comment 4

[don]

Set target meilstone to M7 and changed priority to P5.

Comment 5

[Claudius Gayle]

M7? P5? gosh, can we at least get this release noted for all the preview releases btw now and then?
This is an entirely preventable crash and lots of people crank up the mem alloc on Netscape products to as much as they can
spare, I won't comment on why that is ;-).

Comment 6

[leger]

This is in the M4 Release Notes, and I will confirm it stays in Release Notes of
the future until fixed.  ;-)

Comment 7

[Simon Fraser [no longer active]]

I'm amazed that no-one has made any effort to figure out what's going on here.
ccing some more folks.

Comment 8

[Pierre Saslawsky]

It happens with Viewer too. Reassigned to myself.

Comment 9

[Pierre Saslawsky]

Simon has a fix. Reassigning to him.

Comment 10

[Simon Fraser [no longer active]]

This is caused by a numeric overflow in the memory allocator initialization code.
The fix is pretty simple.

Comment 11

[chris hofmann]

could you do the work to get this on the branch?
if we respin we could pick up this fix...

Comment 12

[Simon Fraser [no longer active]]

I guess so. What's the branch tag?

Comment 13

[chris hofmann]

Seamonkey_M6_BRANCH

http://cvs-mirror.mozilla.org/webtools/bonsai/cvsquery.cgi?module=SeaMonkeyAll&b
ranch=Seamonkey_M6_BRANCH&branchtype=match&dir=&file=&filetype=match&who=&whotyp
e=match&sortby=Date&hours=2&date=week&mindate=&maxdate=&cvsroot=%2Fcvsroot

Comment 14

[Simon Fraser [no longer active]]

I checked in the fix onto the branch:

/cvsroot/mozilla/lib/mac/MacMemoryAllocator/src/nsAllocatorManager.cp,v  <--
nsAllocatorManager.cp
new revision: 1.5.34.1; previous revision: 1.5

/cvsroot/mozilla/lib/mac/MacMemoryAllocator/src/nsAllocatorManager.h,v  <--
nsAllocatorManager.h
new revision: 1.3.34.1; previous revision: 1.3

Comment 15

[Simon Fraser [no longer active]]

Fix checked in to trunk.

Comment 16

[cpratt]

Build 1999060119, rev A iMac, Mac OS 8.6, 40 MB RAM allocated to apprunner = no
crash. Marking verified fixed.

Comment 17

[leger]

Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.