406672 - Please add 'back' and 'forward' stock icons to help viewer under Linux.

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Hussam Al-Tayeb]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120401 Firefox/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007120401 Firefox/3.0b2pre

Stock back/forward/home/print icons are already used in firefox toolbar and bookmark organizer under Linux. Please add those to help viewer as well.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[sikon]

Attachment: Patch

Attaching a patch. The help.css file is taken from winstripe and modified.

Comment 2

[Reed Loden [:reed]]

Comment on attachment 292563 [details] [diff] [review]
Patch

Ryan can review this quicker than mconnor can, most likely. :)

Comment 3

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 292563 [details] [diff] [review]
Patch

This needs a Makefile in help/ (a copy from http://lxr.mozilla.org/seamonkey/source/toolkit/themes/winstripe/help/Makefile.in should do nicely).

>diff -U 8 -urpN toolkit/themes/gnomestripe/help/help.css toolkit/themes/gnomestripe/help/help.css
>+#search-sidebar-closebutton {
>+  border: 1px solid transparent;
>+  padding: 3px 2px 4px 2px !important;
>+  list-style-image: url("moz-icon://stock/gtk-close?size=menu");
>+  -moz-appearance: none;
>+}
Ditch the border, padding and -moz-appearance here.

Looks good otherwise - if you feel like getting rid of the old, silly, all-caps comments, that would be great too :)

Comment 4

[sikon]

Attachment: Patch v2

New try.

Comment 5

[Hussam Al-Tayeb]

Your patch doesn't use 'disabled' back and forward images.

Comment 6

[sikon]

Attachment: Patch including state=disabled

Comment 7

[Reed Loden [:reed]]

Thanks for the patch!

Checking in toolkit/themes/gnomestripe/Makefile.in;
/cvsroot/mozilla/toolkit/themes/gnomestripe/Makefile.in,v  <--  Makefile.in
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/Makefile.in,v
done
Checking in toolkit/themes/gnomestripe/help/Makefile.in;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/Makefile.in,v  <--  Makefile.in
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/help.css,v
done
Checking in toolkit/themes/gnomestripe/help/help.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/help.css,v  <--  help.css
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/themes/gnomestripe/help/jar.mn,v
done
Checking in toolkit/themes/gnomestripe/help/jar.mn;
/cvsroot/mozilla/toolkit/themes/gnomestripe/help/jar.mn,v  <--  jar.mn
initial revision: 1.1
done