Closed Bug 40862 Opened 25 years ago Closed 25 years ago

Make flowed class useable for quoting

Categories

(MailNews Core :: MIME, defect, P3)

Product:
MailNews Core
Component:
MIME
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: BenB, Assigned: BenB)

References

Details

(Whiteboard: r=rhp, a=waterson)

Attachments

(5 files)

Current state of work
11.93 KB, patch
Details | Diff | Splinter Review
Fix, version 2
9.26 KB, patch
Details | Diff | Splinter Review
Fix, version 3
6.88 KB, patch
Details | Diff | Splinter Review
Fix, version 4
6.87 KB, patch
Details | Diff | Splinter Review
Fix, version 5
10.29 KB, patch
Details | Diff | Splinter Review
mime/src/mimetpfl.cpp misses some special cases for the quoting case. Something like writing prefs into the generated HTML (what we do right now) is bad during display, but unacceptable if the HTML code is send out as HTML msg. Check the class if it honors all modes, but at least ...Quoting, ...Bodyquoting and ...SaveAs(HTML) correctly. Basic work for this has been done with bug 31906.
Adding dependencies.
Blocks: 39370
Status: NEW → ASSIGNED
Depends on: 39728
M17 for now.
Target Milestone: --- → M17
Nearly completely fixed with bug 31906. The only remaing issue is doing the right thing for the signature (see bug 9202).
Whiteboard: Nearly completely fixed with bug 31906. Remaing is to do the right thing for sig (see bug 9202).
I have this fixed in my tree. Need to do more testing. Writing out patch in case somebody is interested (Daniel?). Patch contains fix for bug where quoted empty lines are aten, propably introduced by the flowed pp (linebreak) bug. I might file a new bug on this. Daniel, we should file a bug on the nbsp in tag bug as well. (Patch also included.) Some source cosmetic.
Whiteboard: Nearly completely fixed with bug 31906. Remaing is to do the right thing for sig (see bug 9202). → Fixed. Need to test more.
Filed bugs 43455 and 43453 about the other bugs mentioned, so the world is in order :).
Created new patch. Now excludes fix for bug 43455, but still includes fix for bug 43453, because it touches the same part as this one. Daniel, can review the code, please?
Whiteboard: Fixed. Need to test more. → Fixed. Waiting for review, approval, checkin.
Attached patch Fix, version 2 — — Splinter Review
Daniel did a partial review (thanks!). I'll attach a new patch, incorporating the changes. Rich, as Daniel currently can't compile, could you review, please?
Keywords: patch
Attached patch Fix, version 3 — — Splinter Review
The "static" in the patch was unnecessary nonsense. Just remove it.
Attached patch Fix, version 4 — — Splinter Review
Whiteboard: Fixed. Waiting for review, approval, checkin. → Fixed. Waiting for approval, checkin.
Attached patch Fix, version 5 — — Splinter Review
The <div>, with bug 39370 now actually sent out, exposes a bug in 4.x' editor. I removed it in the quoting case (i.e. when a reply is generated). Unfortunately, this removes the information about the source format. I now can't justity anymore to impose a <tt> (which is unnecessary in most case) on recipients. Removing that as well. See "Embed quotes in <tt> or not?" on .mailnews for more info.
Keywords: approval
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Whiteboard: Fixed. Waiting for approval, checkin.
Forgot the r= and a= in the checkin comment :(.
Whiteboard: r=rhp, a=waterson
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: