411648 - Bug 407931 made some CSS too specific.

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

Attachment: Restores the behaviour of the previous CSS.

In Bug 407931 which switched from "buttonstyle" to "mode" some of the CSS was made more specific than previously. Basically the styles in the patch that apply to the "toolbar-1" class should instead apply to all <button>s and <toolbarbutton>s instead. This patch restores the old behaviour (which also removes a contradictory style between toolbar.css and button.css).

Comment 1

[Philip Chee]

s/the styles/some styles/

stefan: I'll need you to help test this patch on OSX.

Comment 2

[Philip Chee]

Attachment: Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

As per discussion over #irc with stefanh and KaiRo. Simplified the CSS by reducing the number of selectors where possible.

Comment 3

[Stefan [:stefanh]]

Comment on attachment 296540 [details] [diff] [review]
Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

r=stefanh, without checking the windows part.

Comment 4

[Philip Chee]

OK I'll test the windows part then.

Comment 5

[Philip Chee]

Comment on attachment 296540 [details] [diff] [review]
Patch v 1.1 Change CSS rules to match the old buttonstyle styles [Simplified CSS]

> OK I'll test the windows part then.

The simplified styles are working in classic. Tested in Navigator and in the main MailNews windows. The changes in modern are working as well except that in Navigator, the .toolbarbutton-menubutton-dropmarker styles are trumped by more specific styles in toolbar.css and navigator.css but this was also the case before the buttonstyle prefs were removed.

Comment 6

[[e-mail]]

I think I remember why I wrote these styles like this; it was so that only toolbarbutton-1 toolbarbuttons got affected by the text/icons mode setting.

So, for instance, bookmark items wouldn't be affected.

Comment 7

[Philip Chee]

The button prefs (both the old style "buttonstyle" and the new style "mode") aren't applied to the Personal Toolbar[1] according to the DOM inspector so this patch doesn't regress the bookmark items in the personal toolbar. Anybody know why? I see the #grippytoolbar bindings attached though.

[1] All this will change if my customizable toolbars patch lands[2]
[2] Which is why that patch has a css section called Personal Toolbar over-rides.

Comment 8

[Reed Loden [:reed]]

Checking in suite/themes/classic/communicator/mac/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/mac/button.css,v  <--  button.css
new revision: 1.17; previous revision: 1.16
done
Checking in suite/themes/classic/communicator/win/button.css;
/cvsroot/mozilla/suite/themes/classic/communicator/win/button.css,v  <--  button.css
new revision: 1.17; previous revision: 1.16
done
Checking in suite/themes/classic/navigator/navigator.css;
/cvsroot/mozilla/suite/themes/classic/navigator/navigator.css,v  <--  navigator.css
new revision: 1.43; previous revision: 1.42
done
Checking in suite/themes/modern/communicator/button.css;
/cvsroot/mozilla/suite/themes/modern/communicator/button.css,v  <--  button.css
new revision: 1.55; previous revision: 1.54
done