41303 - new email tech doesn't work with emailregexp

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Jon Robertson]

The new email tech doesn't seem to work with emailregexp.  It just sends the 
email to login_name, without adding emailsuffix.  Since bugzilla is running on 
a separate machine from our email server, sendmail just reports 'user not 
found' or some such.

None of our bugzilla users have accounts on the actual bugzilla machine.  :)

Comment 1

[Jon Robertson]

This problem also extended itself to the CC list for the new email tech as well.

I'm attaching a patch that corrects this.  I'm not sure if it is how mozilla 
would implement it.  But I like it (and that's why I'm using it!  :)

At the end of NewProcessOneBug, just before NewProcessOnePerson is called, I 
check the format of the person's address using a reg expression that I stole 
from defparams ("^[^@, ]*@[^@, ]*\.[^@, ]*$"), which basically checks to see if 
the address matches x@x.x

If the name does not match that expression, then I append emailsuffix to the 
name.  This corrects the above problems *and* allows someone outside of the 
emailsuffix to be put in the CC list.

Comment 2

[Jon Robertson]

Attachment: Jon's patch for the new email tech / emailregexp / emailsuffix problem

Comment 3

[Jon Robertson]

Darn.  The first diff was a unified diff and it contained some commented test 
code from the first modification I tried.  I'm really sorry...  I'll get the 
hang of this soon I hope...  Here comes another patch.

Comment 4

[Jon Robertson]

Attachment: Jon's corrected patch for the new email tech / emailregexp / emailsuffix problem

Comment 5

[Tara Hernandez]

Chris -- you want to have a look at this one?

Comment 6

[Chris Yeh]

committed to trunk

Comment 7

[Tara Hernandez]

Sorry for the spam, but I needed to be able to query for all of these correctly.

Comment 8

[Dave Miller [:justdave]]

Moving closed bugs to Bugzilla product