413332 - Crash @ nsAccessible::GetCachedFirstChild

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Crash reports:
http://crash-stats.mozilla.com/report/list?range_unit=days&query_search=signature&query_type=contains&signature=nsAccessible%253A%253AGetCachedFirstChild(nsIAccessible**)&query=Accessible&range_value=7

It looks like we're not checking if mFirstChild is not nsnull on line 587.

Comment 1

[Marco Zehe (:MarcoZ)]

Oops, copy & paste error for the link: http://crash-stats.mozilla.com/report/list?range_unit=days&query_search=signature&query_type=contains&signature=nsAccessible%3A%3AGetCachedFirstChild%28nsIAccessible%2A%2A%29&query=Accessible&range_value=7

Comment 2

[Aaron Leventhal]

This isn't a missing null check. It's an old pointer.

The null check is automatically part of NS_IF_ADDREF (as opposed to NS_ADDREF)

Comment 3

[Marco Zehe (:MarcoZ)]

Did you see this creep up anywhere recently, or shold we close as WFM because of our other fixes recently?