419005 - Usage of RSS/Livemark icons on Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Michael Monreal [:micmon]]

There are currently two different RSS/Livemark (16x16) icons: one is just the orange glyph, the other is a white glyph on orange background. Currently they are used in the following places:

- content type (applications prefpane) 
- subscribe (location bar, and action in app prefpane) 
- live bookmark (bookmarks toolbar, library window)

We will make the content type and the live bookmarks the same, they will use the shape-on-orange-background icon. For actions, we will use the background-less glyph.

The inventory lists a special livemark folder (shape-on-orange-background + arrow) for the bookmarks toolbar. We will just use the normal shape-on-orange-background for this instead of browser/places/livemark-folder* (which can probably be removed)

In addition to this, we have matching livemark-item icons ready to be included. The current one is taken from browser/places/livemark-item* I think, can we just replace those with single 16x16 icons?

Comment 1

[Michael Monreal [:micmon]]

Attachment: Livemark item icon

Comment 2

[Michael Monreal [:micmon]]

Attachment: Livemark item icon RTL

Comment 3

[Michael Ventnor]

Attachment: Patch

I couldn't find a way to use the RTL icon yet (indeed the Pinstripe theme doesn't do so either), this will also remove comments that no longer apply.

Comment 4

[Michael Ventnor]

Attachment: Better class

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 305129 [details] [diff] [review]
Better class

livemark-item-rtl.png is a leftover from a time before livemark-folder* existed. The only purpose of the RTL variant was to switch the orientation of the dropmarker image - which isn't used at all anymore and isn't even necessary in gnomestripe now.

http://www.mozilla.org/foundation/feed-icon-guidelines/ explicitly mentions not changing the orientation or displaying the icon in parts - but what's landed recently in all themes already seems to indicate we don't really care anyway ;)

Kudos to reed if he nukes the jar.mn entry and old image on checkin.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305129 [details] [diff] [review]
Better class

a=beltzner

Comment 7

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/places/livemark-item-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/livemark-item-rtl.png,v  <--  livemark-item-rtl.png
new revision: 1.2; previous revision: 1.1
done
Checking in browser/themes/gnomestripe/browser/places/livemark-item.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/livemark-item.png,v  <--  livemark-item.png
new revision: 1.4; previous revision: 1.3
done

Comment 8

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.189; previous revision: 1.188
done

Comment 9

[Reed Loden [:reed]]

(In reply to comment #5)
> Kudos to reed if he nukes the jar.mn entry and old image on checkin.

Will do, as soon as the tree reopens.

Comment 10

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.72; previous revision: 1.71
done
Removing browser/themes/gnomestripe/browser/places/livemark-folder-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/livemark-folder-rtl.png,v  <--  livemark-folder-rtl.png
new revision: delete; previous revision: 1.2
done
Removing browser/themes/gnomestripe/browser/places/livemark-folder.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/livemark-folder.png,v  <--  livemark-folder.png
new revision: delete; previous revision: 1.2
done
Removing browser/themes/gnomestripe/browser/places/livemark-item-rtl.png;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/livemark-item-rtl.png,v  <--  livemark-item-rtl.png
new revision: delete; previous revision: 1.2
done

Comment 11

[Reed Loden [:reed]]

monreal, can you make sure all parts of comment #0 have been addressed?

Comment 12

[Michael Monreal [:micmon]]

The bookmark bar still uses the icon without background, this has to be changed I think. Alex wanted the bookmark bar icons to have the heavier feeling, like folders. The rest seems to be working fine, thanks.

Comment 13

[Reed Loden [:reed]]

Reopening to address comment #12.

Comment 14

[Reed Loden [:reed]]

Attachment: Use feedIcon16.png instead of page-livemarks.png for bookmarks toolbar and places library

Comment 15

[Asaf Romano (gone)]

Comment on attachment 305719 [details] [diff] [review]
Use feedIcon16.png instead of page-livemarks.png for bookmarks toolbar and places library

r=mano.

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 305719 [details] [diff] [review]
Use feedIcon16.png instead of page-livemarks.png for bookmarks toolbar and places library

a=beltzner for 1.9

Comment 17

[Reed Loden [:reed]]

Checking in browser/themes/gnomestripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/browser.css,v  <--  browser.css
new revision: 1.195; previous revision: 1.194
done
Checking in browser/themes/gnomestripe/browser/places/places.css;
/cvsroot/mozilla/browser/themes/gnomestripe/browser/places/places.css,v  <--  places.css
new revision: 1.26; previous revision: 1.25
done