41907 - [FIXr]Eliminate extra CheckLoadURI function in nsXMLElement.cpp

Status: RESOLVED FIXED

(Core :: XML, defect, P3)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

We call mInner.TriggerLink() which will CheckLoadURI as well. The problem is 
that TriggerLink() does not return any information about failed CheckLoadURI.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This is a performance issue, albeit a minor one. This happens only when an XLink 
is clicked. The user is prepared to wait a little while (not that this one check 
causes any visible delay to the user).

This is also a code cleanup task to remove duplicate code.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This isn't that important yet...

Comment 3

[Boris Zbarsky [:bzbarsky]]

This could be eliminated immediately if this check were not using the
DISALLOW_FROM_MAIL flag.  We only need that for auto xlinks, and perhaps the
right thing to do is to change TriggerLink to take a boolean for whether the
triggering is automatic or not (and then pass true for things like auto xlinks).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Somewhat like this, perhaps?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm.. maybe we want to push the security check down into the webshell (inside
OnLinkClickSync)?  That way form submission could use this too (for forms
submitted via submit() or something).  On the other hand, anyone running JS in
email already has issues....

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 141374 [details] [diff] [review]
Somewhat like this, perhaps?

Seems reasonable, r+sr=jst for this, even if we'd decide to move this check
elsewhere.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I'll file a followup bug for any further changes -- they need a good bit of
thought...

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fix checked in for 1.7b