Closed Bug 42016 Opened 24 years ago Closed 24 years ago

Reading some Mail causes seamonkey to freeze or crash

Categories

(SeaMonkey :: MailNews: Message Display, defect, P3)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
All
Windows NT
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: mrp, Assigned: BenB)

Details

(Keywords: crash, Whiteboard: [nsbeta2+])

Attachments

(4 files)

News message from Ben Goodyear
2.82 KB, text/plain
Details
file saved as text/eml
2.82 KB, text/eml
Details
|cd netwerk/streamconv/converters;cvs diff -u mozTXTToHTMLConv.cpp|
2.20 KB, patch
Details | Diff | Splinter Review
Better patch.
2.20 KB, patch
Details | Diff | Splinter Review 
When reading some e-mails, the mailreader barfs & DrWatson is invoked. I don't 
know what is different about those messages, but some messages consistently do 
this.

This is with today's build (2000060820).
Could you please attach some of the mails?
Also, are you using IMAP or POP protocol?  Please attach a protocol log, if 
possible.  

See: http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html

What types of messages are they?  Do they contain web pages?  Do they contain 
attachments?  Are they just plain text messages?

Leave at unconfirmed status until we get some more information.
Keywords: crash
QA Contact: lchiang → pmock
Tested on build build 060814 on Win 98 SE (pop)
I ran across this about 2 weeks ago, and forgot to file a bug (doh!)
When this bug bit me I was in N.P.M.UI
the thread is "skinning delimmma" started 5/26/00 3:17:04 PM
The problem shows up in Ben Goodyear's reply dated 5/28/00 10:42 AM
Ben's reply crashes Mozilla everytime. Checked in NN 4.72 it has no attachments.
thanks.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirmed, it crashes on today commercial seamonkey build on all platforms 
reading that specific news message.  I tested on the following builds:
 win32 commercial seamonkey build 2000-060909-m17 installed on PIII win98
 linux commercial seamonkey build 2000-060908-m17 installed on PII RedHat 6.1
 macos commercial seamonkey build 2000-060908-m17 installed on G3/400 OS 9.04

Changing platform to all
Hardware: PC → All

    
    

    
  
Fyi
On all of my systems, I freeze reading this news message from Ben Goodyear.

    
    

    
  
reassign to rhp.
Assignee: putterman → rhp

    
    

    
  
Can we save that news message as an .eml file (in 4.x) for Rich?

    
    

    
  

      
      
      
      

        Attached file
          
        file saved as text/eml
        — 
      

    


  

    
    

    
  
This seems bad...should investigate.

- rhp
Status: NEW → ASSIGNED
Keywords: nsbeta2
Target Milestone: --- → M17

    
    

    
  
Ben,
If I throw the second attachment into a mail folder and view it, I get caught 
in an infinite loop in TXTtoHTML. 

Can you look at this.

- rhp
Assignee: rhp → mozilla
Status: ASSIGNED → NEW

    
    

    
  
Yes, but I don't run a debug build nor do I know gdb well. Where exactly do you
get the infinite loop?
Status: NEW → ASSIGNED

    
    

    
  
Reduced test cases:
Causes the bug:
@bla "b"
Does not cause the bug:
 @bla b
@bla <b>
@bla ""
<@bla> "b"
@bla> "b"
<@bla "b"


    
    

    
  
> Causes the bug:

|:bla "b"|

> Does not cause the bug:

 @bla "b"

Found the bug: I assumed that |mynsString.RFindCharInSet(set, -1)| always
returns |kNotFound|, but negative offsets have the special meaning of "all of
the string" and thus it returns a hit, if |mynsString| contains chars in |set|.
Attaching patch.

mscott, can you review, please?

Matthew Pocock, thanks for finding and reporting the bug.

    
  
Summary: Reading some Mail causes seamonkey to crash → Reading some Mail causes seamonkey to freeze

    
  
Summary: Reading some Mail causes seamonkey to freeze → Reading some Mail causes seamonkey to freeze or crash

    
    

    
  
forgot to cc mscott. see above.

> |:bla "b"|

You need to remove the "|" to trigger the bug.

    
    

    
  
Patch was bad. Will attach better one.
Whiteboard: Fixed. Waiting for review.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Better patch.
        — 
          — Splinter Review
      

    


  

    
    

    
  
r=mscott

nominating for nsbeta2 so we can check this in. oh someone already did nominate 
it for beta2 =).

    
  
Whiteboard: Fixed. Waiting for review. → Fixed. Waiting for checkin approval

    
    

    
  
Putting on [nsbeta2+] radar for beta2 fix. 
Whiteboard: Fixed. Waiting for checkin approval → [nsbeta2+]Fixed. Waiting for checkin approval

    
  
Whiteboard: [nsbeta2+]Fixed. Waiting for checkin approval → [nsbeta2+]Fixed, r=mscott, a=waterson. Waiting for my checkin account.

    
    

    
  
mscott, if you want, you can check it in.

    
    

    
  
okay i'll check it in.


    
    

    
  
i checked in the fix for benb.

    
    

    
  
tnx.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Whiteboard: [nsbeta2+]Fixed, r=mscott, a=waterson. Waiting for my checkin account. → [nsbeta2+]

    
    

    
  
Fenella - can you help verify?  Open the newsgroup and read the posting 
mentioned in this bug report's comments by John Dobbins 2000-06-09 14:07.  If no 
crash, then this is fixed/verified.  Thanks.
QA Contact: pmock → fenella

    
    

    
  
Verified with build 2000071920. No crash when reading Ben's reply.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: