422920 - context menu "save image as.." broken for <canvas>

Status: RESOLVED DUPLICATE of bug 420230

(Firefox :: General, defect, P2)

Description

[(not currently active) Ted Mielczarek]

Attachment: canvas testcase

Using the context menu "save image as.." on <canvas> is broken for me on Win32. It appears to work on a Mac build from the same day. I get the "save as" dialog, click ok, and it shows up in the download manager, but the file doesn't exist. Filed in General because I don't actually know where this belongs yet.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre

Attachment is a simple canvas testcase.

Comment 1

[:Gijs (he/him)]

I don't supppose you have any idea when this broke? :-(

Comment 2

[(not currently active) Ted Mielczarek]

No, I haven't had a chance to go regression hunting. :-/

Comment 3

[Steve England [:stevee]]

Sorry I didn't realise this was a regression for some reason.

Works: 20080208_1413_firefox-3.0b4pre.en-US.win32
Broken: 20080208_1508_firefox-3.0b4pre.en-US.win32

Checkins to module PhoenixTinderbox between 2008-02-08 14:13 and 2008-02-08 15:08 : 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-08+14%3A13&maxdate=2008-02-08+15%3A08&cvsroot=%2Fcvsroot

Please in future feel free to give me a prod on IRC if you want a range, especially if it's something as easily reproducible as this :)

Comment 4

[(not currently active) Ted Mielczarek]

Thanks Steve! From that list, looks like bug 402452 or bug 408153 are possible culprits. I'd lean more towards 408153 for some reason...

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Jim, Shawn: any ideas if either of your patches caused this?

Comment 6

[Jim Mathies [:jimm]]

This might be a dupe of bug 416683. I'll do some investigating.

Comment 7

[Jim Mathies [:jimm]]

Hmm, I'm not able to reproduce. Ted do you have any anti-virus software on your machine?

Comment 8

[(not currently active) Ted Mielczarek]

Not that I'm aware of. Is there a registry location I could check to see if anything has registered itself as an antivirus provider?

Comment 9

[Jim Mathies [:jimm]]

I think the test scanner timer here should print out enough data - 
https://bugzilla.mozilla.org/show_bug.cgi?id=415005
Bug 416683, comment 6 for an example. That's what kicked off that bug.

Comment 10

[(not currently active) Ted Mielczarek]

This is all I get:
IAttachmentExecute:
18.190355 5.515577 0.001857
0.016624 0.288181 0.000914
0.009507 0.279298 0.000744
0.009372 0.260340 0.000684
0.009154 0.259246 0.000816
0.009041 0.263336 0.000823
0.009105 0.259381 0.000684
0.009338 0.259032 0.000801
0.009082 0.260238 0.000718
0.009041 0.262911 0.000778
0.008996 0.259110 0.000684
0.008996 0.259851 0.000677
0.009135 0.263802 0.000823
0.009165 0.259125 0.000808
0.009244 0.259276 0.000808
0.009154 0.259054 0.000707
0.008962 0.276745 0.000823
0.009237 0.259806 0.000692
0.008985 0.259761 0.000707
0.008943 0.263107 0.000831

Comment 11

[Jim Mathies [:jimm]]

ok, can you try setting browser.download.manager.scanWhenDone to false and testing the save again? That turns the scanning stuff off completely. If it still happens, bug 408153 most likely isn't the culprit.

Comment 12

[(not currently active) Ted Mielczarek]

Works if I toggle that pref. This might be due to the image being a data: URI.

Comment 13

[Jim Mathies [:jimm]]

Ugh, I knew there was a bug similar to this someplace but I couldn't remember where it was. Finally tracked it down  - bug 420230. (also see comments 43, 51, 52, 54 in bug 416682) I think this is a dupe of 420230 but I'd like to do some testing before we mark it as such.

Comment 14

[Jim Mathies [:jimm]]

yep. I'll request blocking on the other one.