42406 - align="start" needs to be added for checkboxes

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Henrik Gemal]

To avoid to ugly UI problem of "selecting" text beyond the text the 
autostretch="never" needs to be added.
Will attach screenshot and patch

Comment 1

[Henrik Gemal]

Attachment: screenshot (before and after autostretch="never")

Comment 2

[Henrik Gemal]

Attachment: autostretch="never" added where needed

Comment 3

[sairuh (rarely reading bugmail)]

added patch kw so this can be reviewed/checked in. over to ben who owns the pref
ui.

Comment 4

[Blake Ross]

I'll review and check this in tomorrow

(Henrik: thanks for the patch, but unified diffs are preferred and easier to 
read. just specify the -u parameter)

Comment 5

[Blake Ross]

morse, do you approve of the cookie changes here?

Comment 6

[Stephen P. Morse]

I don't disapprove.  However, I'm not sure if I'm the owner here or not.  I'm 
the owner of all cookie and wallet UI but ben is the owner of the pref panels.  
This is that fuzzy area between the two so I guess you could argue that 
either one of us is the owner.  If I'm the owner, I approve.

Comment 7

[Blake Ross]

Want to do this throughout prefs dialog.

Comment 8

[Blake Ross]

I'll take this back if I get time later.

Comment 9

[Viswanath Ramachandran]

nav triage: this is not a beta stopper.

Comment 10

[Henrik Gemal]

basiclly it now seems that only checkboxes are affected. Most others are 
correct. What is the correct way of fixing this one?
Byt adding autostretch="never" to the checkbox itself???

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 12

[Henrik Gemal]

what does "a=[e-mail]". You are gonna do it?

Comment 13

[Håkan Waara]

This was checked in today thus marking fixed. Btw, where's the r=?

Comment 14

[Blake Ross]

Thanks, but I'm well aware of what I checked in, and I left this open for a 
reason -- to fix remaining cases.

Comment 15

[Stephen Walker]

Attachment: patch for bookmarks, forms, passwords, images & cookies pref panels

Comment 16

[Stephen Walker]

Adding patch & review keywords

Comment 17

[timeless]

r=timeless. does a=ben still apply?

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

yes. a=ben for the most recent patch

Comment 19

[Blake Ross]

Stephen: thanks for the patch.

Since when are bugs on which the owner has worked reassigned without the owner's 
permission?  Back to me; there's still work to be done here.

Comment 20

[Stephen Walker]

Attachment: patch pref-winhooks.xul

Comment 21

[timeless]

r=timeless

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

sr=ben. Hm. I didn't place the autostretch box around this because this type of
thing causes problems when the window is made smaller or the text grows in
length. However this is a bug in the widget that should be separately addressed.

We'd really like to not have to put autostretch boxes around all these things. 

Comment 23

[Henrik Gemal]

"However this is a bug in the widget that should be separately addressed."
has this been reported?

Comment 24

[[e-mail] (gone - use [e-mail] instead)]

Fix is in.

Comment 25

[Henrik Gemal]

missing checkboxes:
- Advanced -> "Enable JavaScript for Mail and News"
- Advanced -> System -> "Alert me if other applications...."

Comment 26

[Henrik Gemal]

If I have other places where this is missing (but not in prefs) should I just 
file new bugs?

Comment 27

[Blake Ross]

usability/polish 0.9.4.

Comment 28

[[e-mail]]

Changing summary to reflect new XUL 1.0 layout changes.

Comment 29

[Peter Trudelle]

Mass moving lower-priority bugs to 0.9.6 (with Blake's pre-consent) to make room
for remaining 0.9.4/eMojo bugs and MachV planning, performance and feature work.
 If anyone disagrees with the new target, please let me know.

Comment 30

[Blake Ross]

Marking fixed, will handle other cases as they crop up.

Comment 31

[sairuh (rarely reading bugmail)]

much nicer. vrfy fixed:

linux - 2001.11.01.12
winNT - 2001.10.31.03
mac 10.1 - 2001.10.31.13