42491 - No Text Limit On Personal Toolbar Items on Classic

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Dan Nunn]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; m16) Gecko/20000613
BuildID:    2000-06-13-20

There is no limit on text in the items in the Personal Toolbar menu, as there
are in 4.x.

Reproducible: Always
Steps to Reproduce:
1. Add a lengthy item to your Personal Toolbar menu (for example, I have one
entitled "Slashdot:News For Nerds. Stuff that matters.")
2. Observe as Mozilla fits the entire text onto the button.

Actual Results:  The entire text is shown.	

Expected Results:  Text should be limited for space reasons, as it is in 4.x.

Comment 1

[Blake Ross]

valid concern

Comment 2

[Blake Ross]

changing qa to claudius

is this an XPApps issue?

Comment 3

[Claudius Gayle]

I'd say, changing componet to Bookmarks (an XP app) and cc'ing rjc.

rjc is this one for you?

Comment 4

[Robert John Churchill]

Hmmm... might want to try giving this to Ben... see if there is some CSS 
property to set maximum widths on text.

Comment 5

[Claudius Gayle]

so it shall be. -->Ben

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

I have a fix for this on my notebook. 

Comment 7

[Dan Nunn]

Fixed on Modern, still open in Classic

Comment 8

[cheng]

I am using modern and I am still seeing this on 2000080120 M18 on Linux, but
perhaps it shows up in a slightly different way.  If I have a long bookmark, the
space allocated to the bookmark is not enough to hold the entire title, and part
of the title actually runs into the next button.  I'll attach a screenshot to
show what it looks like.

Comment 9

[cheng]

Attachment: screenshot of long title on Linux

Comment 10

[Dan Nunn]

Hmm, Win98 Modern is fixed, Classic hasn't been touched. I haven't experienced
your issue on win98. Attached screen shot of both Modern and Classic, 2000-08-01-08.

Comment 11

[Dan Nunn]

Attachment: Personal Toolbar (bug 42491)

Comment 12

[Paul Chen]

nav triage team: looks like css/xul changes just need to be replicated over to classic skin, reassinging to moi to get this thing of 
ben's plate

Comment 13

[Dan Nunn]

Was fixed in Classic for awhile, now it seems to be broken again (classic only, 
modern is fine). However, instead of the buttons expanding to as much as 
necessary, they now are the maximum button size with the text extending well 
beyond the button. Attaching a screen shot of my "Daily News - Mozillazine! Your 
source for Mozilla news and advocacy" bookmark.

Comment 14

[Dan Nunn]

Attachment: Classic 082108 lengthy bookmark text

Comment 15

[johng]

nav triage team:
P2, keywords classic, regression

Comment 16

[cheng]

This bug is not limited only to Classic!  See my attached screenshots for Linux
which still appears on today's built.  (Should OS be changed to all?)

Comment 17

[Claudius Gayle]

I do NOT see this with the modern skin. I'm looking at a 2000082208 Linux build and long bookmark names are cropped (http://
foobar...) in the modern skin and are not in the Classic.

Comment 18

[cheng]

I am definitely seeing this on Modern (on two different machines) on Linux
2000082208 (see attached screenshots from long ago).

Comment 19

[timeless]

Solaris Intel Mozilla built from cvs tip [today]
Toolbar has:
a) This is a very length bookmark that i'm making to test something.
b) Tinderbox
-
Modern: ^Home vThis is... vTinderbox
Classic: ^Home|vThis is a very le[vTinderbox]hat i'm making to test something.
[...] is struck through by 'ngthy Bookmark t'
Nothing after x is hot.
Blue: looks just like modern [maybe this isn't a real theme?]

Comment 20

[Joe Hewitt (gone)]

I have a fix for this.  The problem is that the personal toolbar buttons have a 
binding attached to them in classic which gives them an anonymous image and 
text component.  The text component inherits crop, but it doesn't get the max-
width CSS attribute of it's parent, and therefore overflows.

My fix sets the max-width of the main box to 10em, the max-width of the text to 
8em, and the max-width of the icon to 2em.  This seems sort of hack-ish to me, 
though.  I got those sizes from the max-width settings being used on modern.  

Paul, before I check this in, can you let me know if this seems right to you?

Comment 21

[Paul Chen]

Joe, hackish is what Netscape is ALL about! ;-) Go for it. We can tweak for
aesthetics later, I hope.

Comment 22

[cheng]

I know that this bug was marked as "Classic" skin only, but has I am still
experiencing problem (which I have included a screenshot of a while ago) with
all skins on Linux 2000090508.  I am guessing that the patch only fixes
classic.   I thought the original form of the bug is exactly what I see on my
Linux boxes, but it seems to have evolved into something else :(. Should I open
another bug for what I see?

Comment 23

[Kevin Higgins]

Attachment: toolbarshot2

Comment 24

[cheng]

Okay, I now know why everyone saying that it works on Modern while I keep on
seeing the bug.  The reason is that everyone is using plain bookmarks in the
personal toolbar, but if you look at my attached screenshot, I put folders with
long names.  In particular, this bug is not fixed for folders in Modern,
Classic, or Blue.

Comment 25

[Kevin Higgins]

Attachment: Screenshot - adding a folder instead of bookmark

Comment 26

[cheng]

Should I change the summary and keywords to remove "classic", since this is not
limited to classic? (see my last comment)

Comment 27

[Blake Ross]

*** Bug 51558 has been marked as a duplicate of this bug. ***

Comment 28

[Phil Peterson]

PDT thinks this is a P3 since there's an obvious workaround. 

Comment 29

[Joe Hewitt (gone)]

This one is fixed now.

Comment 30

[cheng]

The problem with long folder names on the toolbar is fixed on Linux 2000091306
with both Modern and Classic, but not Blue.

Comment 31

[Joe Hewitt (gone)]

Blue is no longer a theme which is being supported by Netscape.  Anyone who 
wishes to keep blue up to speed with modern and classic is free to do so!

Comment 32

[Blake Ross]

*** Bug 49427 has been marked as a duplicate of this bug. ***

Comment 33

[verah (gone)]

Nav triage team: This is fixed; if anyone wants to file a bug to bring Blue skin 
up to speed on this please file a separate bug. Thanks!

Comment 34

[Claudius Gayle]

VERIFIED Fixed with 2000113004 builds