42634 - nsSliderFrame::GetContentOf hides inherited method

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Kathleen :Brade]

on the Macintosh tinderbox Warning page, I see these warnings which should be 
investigated:

nsSliderFrame::GetContentOf(nsIBox *, nsIContent **)' hides inherited virtual 
function 'nsBoxFrame::GetContentOf(nsIContent **)

Comment 1

[Mike Pinkerton (not reading bugmail)]

evaughan

Comment 2

[Eric Vaughan]

targeting

Comment 3

[John Morrison]

moving all evaughan non-nsbeta3+ bugs to Future milestone, per trudelle

Comment 4

[Boris Zbarsky [:bzbarsky]]

Just renaming the method would make the warning go away (and make things
clearer, imo).

Comment 5

[Marc Loiselle]

Attachment: Removes "GetContentOf is hidden" warning

Rename nsSliderFrame::GetContentOf to nsSliderFrame::GetContentOfScrollbar. 
The method is private is only used by nsSliderFrame.cpp.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 124149 [details] [diff] [review]
Removes "GetContentOf is hidden" warning

I'd prefer "GetContentForBox" since that's what the function does.

Comment 7

[Marc Loiselle]

Attachment: Removes "GetContentOf is hidden" warning v2

GetContentOfBox() instead of GetContentOf() to fix compiler warning

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 124245 [details] [diff] [review]
Removes "GetContentOf is hidden" warning v2

I don't see any reason for this to be a (non-static) member function -- it just
means you're passing around an extra |this| pointer that you don't need. 
However, why should it be a member at all?  How about:

static already_AddRefed<nsIContent>
ContentOfBox(nsIBox *aBox)
{
  nsIFrame *frame;
  aBox->GetFrame(&frame);
  nsIContent *content;
  frame->GetContent(&content);
  return content;
}

Comment 9

[Marc Loiselle]

Attachment: Removes "GetContentOf is hidden" warning v3

Add static GetContentOfBox() function.	Remove nsSliderFrame::GetContentOf().

Comment 10

[Marc Loiselle]

dbaron, Can you check-in for me?

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-06-01 19:39 -0700.