427164 - jsdIScript.isLineExecutable should return NS_ERROR_OUT_OF_MEMORY for oom

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[John J. Barton]

In FF3pre I get exceptions like this one

Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [jsdIScript.isLineExecutable]

for lines like this one:

if (script.isValid && script.isLineExecutable(scriptLineNo, this.pcmap_type))

1) Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040404 Minefield/3.0pre

2) Firebug 1.2a13X or 1.2 SVN >R498

3) http://speedmeter.de/

NOTE: I also get two out of memory errors so it possible that the OOM should be looked at first in case that makes the state invalid. I put depends on to the OOM report

Comment 2

[timeless]

this error result only happens in OOM cases, i'll fix it, but i don't see why you think this is particularly important.

Comment 3

[timeless]

Attachment: report oom, don't leak lineMap on realloc failure

Comment 4

[John J. Barton]

(In reply to comment #2)
> this error result only happens in OOM cases, i'll fix it, but i don't see why
> you think this is particularly important.
> 
Its important in two ways:
  1) If this is new API (throw normal) I have to re-write my code. It's not: good!
  2) The OOM is bogus and common: we need to know why.
Thanks
John.

Comment 5

[Brian Crowder]

I think either this bug is fixed or the dependency on 422137 is bogus.  timeless, please weigh in?

Comment 6

[timeless]

Comment on attachment 314045 [details] [diff] [review]
report oom, don't leak lineMap on realloc failure

this is a small localized change to improve error reporting and oom handling in jsd. jsd is used by venkman and firebug (and iMacros...).

Comment 7

[Mike Schroepfer]

Comment on attachment 314045 [details] [diff] [review]
report oom, don't leak lineMap on realloc failure

only taking zero risk (e.g. css) or showstopper issues at this point.  If this
is one of those please re-nom and let me know.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/9ffef99c9aa7

Comment 9

[John J. Barton]

adding to the firebug tracking list