429666 - Expose ROLE_DOCUMENT for ARIA landmarks that inherit from document

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

At least 1 ARIA landmark inherits from "document" -- it's role="article".

For the ATK/MSAA enumerated roles we are supposed to expose the closest role. In this case that would be ROLE_DOCUMENT.

I'll have to check to see if there are other sitatuons like this.

Comment 1

[Aaron Leventhal]

Attachment: Support article with ROLE_DOCUMENT

There are no other descendant roles for document.

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT

r=me

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 316809 [details] [diff] [review]
Support article with ROLE_DOCUMENT

Tests?  Explanation of risk?  Re-request approval once addressed.

Comment 4

[Marco Zehe (:MarcoZ)]

Aaron, is there a test page I could use for a Mochitest for this one?

Comment 5

[Aaron Leventhal]

Attachment: Testcase: just use role="article"

Comment 6

[Marco Zehe (:MarcoZ)]

Attachment: Patch containing both original patch and Mochitest

Original patch by Aaron, this also contains a Mochitest for it.

Comment 7

[alexander :surkov (:asurkov)]

Comment on attachment 325233 [details] [diff] [review]
Patch containing both original patch and Mochitest

r=me.
Though I would suggest to call the file as "test_aria_role_article". We have already the file (test_aria_activedescendant). It should be easier to find out that file and extend test in the future.

Comment 8

[Marco Zehe (:MarcoZ)]

Pushed in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/cc03e7e0747b

Comment 9

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008062603 Minefield/3.1a1pre