43082 - datasource rdf:bookmarks should not be require to startup

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Doug Turner (:dougt)]

if the nsHTMLDocument can not file someone that implements the datasource 
rdf:bookmarks, we can not start up.

See:

http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/nsHTMLDocument.
cpp#735

I suggest not setting |rv| if you can not find this datasource.

Comment 1

[Robert John Churchill]

Chris, want this?  I agree that if a datasource fails to load, startup should 
still continue.  Of course, I also think that we need some way (via JS? A new 
(set of) events?]  to indicate both success as well as failure.

Comment 2

[Robert John Churchill]

Oops, sorry... this layout code is jbetak's, so I'm going to bump this bug over 
to him.

Comment 3

[Doug Turner (:dougt)]

This should be fixed for embedding reasons as soon as possible.

Comment 4

[Frank Tang]

reassign jbetak bug to ftang since jbetak is leaving.

Comment 5

[Doug Turner (:dougt)]

nom for beta2!

Comment 6

[Phil Peterson]

nsbeta2+ to fix enough to make embedding clients work

Comment 7

[Frank Tang]

jbetak- please fix the error handling part. Thanks.

Comment 8

[Doug Turner (:dougt)]

Attachment: proposed patch

Comment 9

[Frank Tang]

dougt- jbetak already review yoru code and give an OK. Please check it in. If 
you prefer us to own this bug, then reassign to me and I will check this in 
tomorrow for him. (sorry, I won't be here the rest of today.). jbetak is leaving 
so I don't want him to check in code from now.

Comment 10

[Doug Turner (:dougt)]

fix is in.  thanks.

Comment 11

[Claudius Gayle]

code-level fix, marking verified.

Comment 12

[Doug Turner (:dougt)]

work around checked in.  We should really figure out why we have to have layout 
know about bookmarks.  This dependancy seams really wrong.

removing nsbeta2

Comment 13

[Scott MacGregor]

Adding myself to the cc list. 

Comment 14

[Doug Turner (:dougt)]

frank, this is yours.  Currently there is a workaround in place.  We need to
have a better place for this hook.  

Comment 15

[Frank Tang]

dougt- could you please be more specific of your requirement ? How can I measure 
we have a good enough fix for this bug ?

Comment 16

[Scott MacGregor]

Frank: right now, this change has made a dependency where layout uses bookmarks
in order to load an html document. This is a really evil dependency. It looks
like it's being used to get the charset from the last url added to bookmarks.
Layout should not be using bookmarks.

I think Doug's request is that we need a different way to expose the information
you need in nsHTMLDocument::StartDocumentLoad so it isn't trying to
create/instantiate bookmarks.

See comments in Bug #44397 for more details. Hope that helps.

Comment 17

[Judson Valeski]

+

Comment 18

[Frank Tang]

Why we need this for nsbeta3 ? What will happen if we don't fix this ? What will 
happen if we do fix it ? What is the impact to end user? What is the impact to 
the embedding project ?

Comment 19

[Judson Valeski]

if we don't fix this embeddors have to drag bookmarks into memory even though 
they don't need them. This adds to bloat. Who's the right owner for this. We 
need to resolve this ASAP.

Comment 20

[Frank Tang]

Can we resolve this by #ifndef EMBEDDING_OR_SOMETAG that part of the code? Will
that resolve your problem. Please let me understand your MINIMUM requirement and
we can try to meet it quickly.

Comment 21

[Doug Turner (:dougt)]

We are doing a CI in layout to do some i18n thing to get the bookmarked charset.  
Before my workaround, if CI failed, we could not load any pages.  I hacked it so 
that it would silently fail.  For better or worse, this broke the evil dependacy 
which jbetak? created.  What I need you to do is tell my why we need to 
bookmarks to do this charset stuff.  

Comment 22

[Judson Valeski]

minusing this and removing "embed" keyword. the checked in workaround will get 
us by for embedding. the dependency is horrible and should still be removed 
however.

Comment 23

[leger]

Putting brackets in - from nsbeta3- to [nsbeta3-]

Comment 24

[Erik van der Poel]

Brian, please investigate this.

Comment 25

[kill this account]

we are just now looking at the embedding APIs

Comment 26

[kill this account]

--> ftang

Comment 27

[Frank Tang]

bulk move NEW FUTURE bug to ASSIGN

Comment 28

[Jeroen]

Attachment: xul window with template for rdf:bookmarks

load from chrome url

Comment 29

[Frank Tang]

what a hack. I have not touch mozilla code for 2 years. I didn't read these bugs
for 2 years. And they are still there. Just close them as won't fix to clean up.

Comment 30

[Travis Chase]

Mass Reassign Please excuse the spam

Comment 31

[Travis Chase]

Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all
the spam is his fault feel free to tar and feather him

Comment 32

[Travis Chase]

Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam

Comment 33

[Simon Montagu :smontagu]

This seems to have been fixed by bug 101995. Boris, is that correct?

Comment 34

[Boris Zbarsky [:bzbarsky]]

You mean comment 12, not this bug as originally filed?  Yes, indeed.

Comment 35

[Simon Montagu :smontagu]

Right, it was reopened at the same time as comment 12, after having been marked fixed when attachment 10655 [details] [diff] [review] was checked in.