44036 - Search pref UI default settings

Status: VERIFIED WORKSFORME

(SeaMonkey :: Search, defect, P3)

Description

[johng]

Search pref panel does not have its correct defaults preselected in the NSCP 
build:

- "Select Default engine" should have an engine preselected and visible.
- "Search result" to auto open the Sidebar search tab, should be checked by 
default (German's pref was not prechecked with 06/27/00 build, Gable's build of 
the same day was prechecked ...)

Comment 1

[johng]

nsbeta2 nominee

Default search settings an extremely important issue

Comment 2

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 3

[don]

Matt, can you fix this?

Comment 4

[don]

John,

Michael and Sol say they can live without this for beta 2.

Comment 5

[leger]

Putting on [nsbeta2-] per Nav Beta2 review today.  

Comment 6

[johng]

nav triage team:
nsbeta3+ because search usability and defaults are a big deal

Comment 7

[matt]

the default sidebar opening is set by default.
http://lxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js#109

Comment 8

[Daniel Veditz [:dveditz]]

Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.

Comment 9

[Claudius Gayle]

*** Bug 48479 has been marked as a duplicate of this bug. ***

Comment 10

[matt]

assinging priorty to comply with management

Comment 11

[matt]

I have the fix in hand for this bug.
Tree just needs to be opened up.

Comment 12

[matt]

fixed

Comment 13

[Robert John Churchill]

Re-opening.  Ah... Matt, this is wrong (you can't specify your machine's path in 
the pref, as it'll only work on your machine... which looks to be a Windows 
box!):

pref("browser.search.defaultengine", 
"engine://
D%3A%5Cmozilla%5Cdist%5CWIN32_D.OBJ%5Cbin%5Csearchplugins%5CNetscapeSearch.src");

Comment 14

[Phil Peterson]

PDT agrees P2

Comment 15

[Robert John Churchill]

Matt, with your latest set of changes in pref-search.js it looks like the index
to the default-engine is hard-coded:
    engineList.selectedIndex = 6;

That's bad... as the list of categories & engines will change for RTM, as well
as it'll be wrong on the Mac (which imports other Sherlock files in from the Mac
OS), as well as be incorrect if the user adds new search engines (as one can via
Tinderbox, for example).

Comment 16

[matt]

K, then i should get go thought the values to find which select matches
with Netsape Search.

Comment 17

[Robert John Churchill]

Yeah, definitely try to match against "NetscapeSearch.src"  ... actually, I 
thought that there was code somewhere (either in the search preferences panel, 
or maybe the search sidebar panel) that already did just that.

Comment 18

[don]

Gotta fix this for RTM ...

Comment 19

[johng]

nav triage team:
[RTM NEED INFO] is our way of asking for a patch so we can add rtm+ and check it in.

Comment 20

[don]

Gramps sez this is P3.  Move along.

Comment 21

[don]

Vera just check this with the beta build and it actually seems to be working OK
now.  Go figure.

Comment 22

[sairuh (rarely reading bugmail)]

mass-verifying WorksForMe bugs which haven't changed since 2001.12.31.

set your search string in mail to "EmperorLondoMollari" to filter out these
messages.