44117 - Alerts (and other modal windows) are application modal rather than window modal

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[vidur (gone)]

Modal windows are constrained to sit on top of all application windows rather 
than just the parent window. This may be correct behavior on the Mac, but isn't 
correct on Windows. The patch below fixes the problem, though not very cleanly - 
ideally we'd avoid having platform-specific #ifdefs in platform-independent 
code.

Index: src/nsXULWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/xpfe/appshell/src/nsXULWindow.cpp,v
retrieving revision 1.40
diff -u -r1.40 nsXULWindow.cpp
--- nsXULWindow.cpp     2000/06/21 22:05:23     1.40
+++ nsXULWindow.cpp     2000/06/28 20:39:19
@@ -137,8 +137,12 @@

 NS_IMETHODIMP nsXULWindow::GetZlevel(PRUint32 *outLevel)
 {
+#ifdef XP_MAC
    // report our known zlevel, or be on top if currently modal
    *outLevel = mContinueModalLoop ? nsIXULWindow::highestZ : mZlevel;
+#else
+   *outLevel = mZlevel;
+#endif
    return NS_OK;
 }

Comment 1

[vidur (gone)]

Nominating for nsbeta2, since it's a very obvious UI flaw.

Comment 2

[Blake Ross]

I just mentioned this recently...I'm pretty sure it's been reported

Comment 3

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[Dan M]

Modal windows are no longer forced to the top on Windows

Comment 5

[Blake Ross]

I do the following:

(1) Open a browser instance
(2) Spawn a new instance
(3) Open Preferences in the new instance
(4) Switch back to the original instance

The preferences window is still on top of the original instance, but not modal 
to that window.  However, it shouldn't even be on top of the window, should 
it?  Is that not within the scope of this bug?

Comment 6

[Dan M]

  Yes, that's the same bug. It won't do that any more starting with tomorrow 
morning's build.

Comment 7

[sairuh (rarely reading bugmail)]

vrfy using commercial opt bits on winnt, 2000.07.11.08.

Comment 8

[verah (gone)]

*** Bug 43800 has been marked as a duplicate of this bug. ***