Closed
Bug 44164
Opened 24 years ago
Closed 24 years ago
improperly parented modal dialog in nsPop3Protocol
Categories
(MailNews Core :: Networking: POP, defect, P3)
MailNews Core
Networking: POP
Tracking
(Not tracked)
VERIFIED
FIXED
M17
People
(Reporter: danm.moz, Assigned: jefft)
References
Details
(Whiteboard: [nsbeta2+])
Attachments
(1 file)
3.43 KB,
patch
|
Details | Diff | Splinter Review |
nsNetSupportDialog should only be used as a backup plan if no other nsIPrompt interface is available. It has been used in dozens of places because of its seductive convenience. But it's flawed, creating modal windows that don't behave correctly; the cause of various blanket bugs like 25684 and 39439 (both currently considered nsbeta2+). This problem can only be fixed by trying much harder to find a proper window to be the modal dialog's parent. nsNetSupportDialog should be relegated to providing backup when herculean efforts to locate the actual parent window fail for some reason. As an example, the cookie service has been taught to use a proper parent window for its dialog by laboriously storing a reference to that window's nsIPrompt in nsHTTPChannel, from which it can be extracted and passed around while processing notification events, punting to nsNetSupportDialog only when no other choice is available. That same sort of thing needs to be done in many more places. One such place is nsPop3Protocol::Error(). Happy recipients of this bug would spread the happiness most widely if they would start using a good nsIPrompt window. The "modal windows don't behave nicely" bugs are being made dependent on this bug and its siblings, and will eventually be closed as "as fixed as they're going to get" once these have all been considered.
Accepting and nominate for nsbeta2+....
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Per scott on verification: code inspection is the only way. I'd suggest getting an engineer who is helping you verify bugs to look at them.
Keywords: verifyme
What dialog is generated by this code? Would a dialog telling the user that s/he has entered an incorrect password be sufficient? I can then check the modality fo this dialog.
Updated•20 years ago
|
Product: MailNews → Core
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•