441991 - Test for nsXULListitemAccessible::GetName uses self referential aria-labelledby correctly.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Using a listitem its not possible to assign the accessible name using a different node, and the label attribute of the listitem itself. Example snippet:

  <listbox id="reminder-listbox">
    <listitem id="115e5dda"
              label="The moment the event starts"
              aria-labelledby="reminder-action-DISPLAY 115e5dda"/>
  </listbox>
  <menulist id="reminder-actions-menulist">
    <menupopup>
      <menuitem id="reminder-action-DISPLAY"
                value="DISPLAY"
                label="Show an Alert"/>
      <menuitem id="reminder-action-EMAIL"
                value="EMAIL"
                label="Send an E-mail"/>
    </menupopup>
  </menulist>

The listitem should read: "Show an Alert The moment the event starts".

I was told one of the Problems is that nsXULListitemAccessible::GetName prefers the label attribute over aria-labelledby. Another problem is probably the use of recursion.

I would expect that if aria-labelledby refers to the node it is set on, that the label attribute is used instead of aria-labelledby again.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

Philipp, can you run with this patch and see if it gives you the right result?

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Status?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Last I remember, this didn't change anything. I think we talked about this briefly last year, but I don't remember what we came out with.

Comment 4

[alexander :surkov (:asurkov)]

Somebody should check this again since we changed and cleaned up name calculation algorithm.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: test passes

Confirmed via automated test that this is fixed; almost certainly by Alexander's name calc refactor. Not this patch adds a test to confirm the problem case; but there is somewhat similar existing test already. It is probably good to add this one?

Comment 6

[alexander :surkov (:asurkov)]

Comment on attachment 384235 [details] [diff] [review]
test passes

good, thanks, r=me

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 384235 [details] [diff] [review]
test passes

Requesting additional review from Marco to confirm.

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 384235 [details] [diff] [review]
test passes

>+  <!-- bug 41991; create name from other menuitem label listitem's own label -->

One 4 missing at the beginning of the number.

r=me, thanks!

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Thanks fixed bug numbering.

Pushed as changeset: http://hg.mozilla.org/mozilla-central/rev/962a732f1d8a