44363 - Put out linebreaks in HTML for format=flowed

Status: VERIFIED WORKSFORME

(MailNews Core :: MIME, defect, P4)

Description

[Ben Bucksch (:BenB)]

With some of my recent changes changes, we currently put out one lone HTML line
for format=flowed. Not very readable. We should insert a linebreak e.g. after
each source line.

Question: That linebreak exactly? |'\n'|? |NS_LINEBREAK|?

Comment 1

[Daniel Bratell]

If it's for the layout engine it really doesn't matter. I'm not sure what 
NS_LINEBREAK contains but \n is just one byte so you could save one byte per 
line break *pause for applause* :-).

Comment 2

[Ben Bucksch (:BenB)]

Daniel, the output is also used for quotes (which we later send out, if sent as
HTML) and SaveAs. That's why it matters. Some people read the HTML source of
msgs they recieve.

Comment 3

[Daniel Bratell]

But that's after the data has passed some composer window and then been 
converted to HTML (from XIF or what it's called). But why don't you just check 
what happens? In the mail it should be CRLF and I think it will be that no 
matter what you end lines with in the mime classes.

Comment 4

[Ben Bucksch (:BenB)]

> But that's after the data has passed some composer window

Not for SaveAs. Rich and akk said something about that running through the
"output system", but I don't know what that is. I'll just try out their
recommondations, when I have time.

Comment 5

[Ben Bucksch (:BenB)]

I don't know why, but it seems to be fixed. WORKSFORME.

Comment 6

[pmock]

Verified as worksforme on win32, linux, and macos using the following builds:
 win32 commercial seamonkey build 2000-091906-m18 installed on P500 Win98
 linux commercial seamonkey build 2000-091906-m18 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-091904-m18 installed on G3/400 OS 9.04