44446 - Disable struct phrase->style conv for HTML->HTML by default

Status: VERIFIED FIXED

(MailNews Core :: MIME, defect, P3)

Description

[Joe Francis]

The structured phrase<->style conversions supplied by mail should be off 
(regardless of pref settings) when a message going out as html was also composed 
as html.  In these circumstances the author has all the tools at hand to say what 
they mean.  If they want underline they can directly author it.  So if they don't 
do that, but type "_foo_", we must assume "_foo_" is what they indeed want and 
leave it alone.  This kind of aggressive content alteration can really turn off 
users.

Comment 1

[Ben Bucksch (:BenB)]

We only do "plain text conventions for structed phrases"->"HTML for structures
phrases" ("styles") for HTML->HTML.

I already fixed this, patch in bug 43047, waiting for approval. Taking bug.

Comment 2

[Ben Bucksch (:BenB)]

Changing SUMMARY not to give a false impression. The regognition itself is very
conservative and not at all aggressive.

Comment 3

[Ben Bucksch (:BenB)]

Attachment: Pref UI removed

Comment 4

[Ben Bucksch (:BenB)]

Attachment: Changing fallback default in cpp code

Comment 5

[Ben Bucksch (:BenB)]

Removed the Pref UI for this feature completely. Hidden pref still there.

Joe, r=jrancis for the additional changes?

Comment 6

[Joe Francis]

I'm confused.  This bug was about not doing conversions in html->html.  But 
instead I see comments about removing UI.  Ben, fill me in.  The ui removal is 
for all struct conversions, right?  But the default change is just for html->
html, right?  Why are we removing ui?  

Comment 7

[Ben Bucksch (:BenB)]

> The ui removal is for all struct conversions, right?

No, the UI I removed is only for the pref of which we change the default. I.e.
you won't be able to enable (via the UI)
- HTML->HTML conversion
- of structs
- during mail send
anymore, everything else is unchanged.

Comment 8

[Joe Francis]

ok, sounds fine.  I reviewed the attachments.  r=jfrancis

Comment 9

[Ben Bucksch (:BenB)]

Checked in. Forgot the r= and a= in the cvs comment again :-(, see status
whiteboard.

The HTML->HTML conversion of structs is now only reachable via an hidden pref.

Comment 10

[Brendan Eich [:brendan]]

Total style nit about code just after the patch: 'whattodo = whattodo | ...'
should be 'whattodo |= ...' in C-like languages.

/be

Comment 11

[Ben Bucksch (:BenB)]

brendan: yes, didn't know this variant exists. will change at the next chance.

Comment 12

[pmock]

Verified as fixed on win32, linux, and macos using the following builds:
 win32 commercial seamonkey build 2000-092909-mn6 installed on P500 Win98
 linux commercial seamonkey build 2000-092909-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-092911-mn6 installed on G3/400 OS 9.04