44774 - When CurrentPage/selectAll() is invoked and no URL is loaded, then JVM crashes

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Oleg Khokhlov]

When selectAll() is invoked and no URL is loaded, then JVM crashes:

###!!! ASSERTION: You can't dereference a NULL nsCOMPtr with operator->        
().: 'mRawPtr != 0', file ..\..\..\dist\include\nsCOMPtr.h, line 625

#
# HotSpot Virtual Machine Error, EXCEPTION_ACCESS_VIOLATION
#
# Error ID: 4F533F57494E13120E43505002B7
#

abnormal program termination


Build Date & Platform:
Mozilla M16, Webclient source from July,7; WinNT 4.0 with SP4

Comment 1

[leger]

Adding crash keyword.

Comment 2

[edburns]

selectAll is Ashu's.

Comment 3

[Ashu Kulkarni]

Attachment: diffs in CurrentPageImpl.cpp and jni_util.h

Comment 4

[Ashu Kulkarni]

Checked in fix. Pls see attachment for patch

Comment 5

[Oleg Khokhlov]

JVM still crashes.

Possible solution:

in string "rv = initContext->docShell->GetContentViewer(&contentViewer);" method 
GetContentViewer(&contentViewer) always returns NS_OK and rv is always 0.
So we need to check contentViewer value not rv.
We need to change string  "if (NS_FAILED(rv)) {" with string "if 
(contentViewer==nsnull) {".

I tested it and it works. Thanks.

Comment 6

[Ashu Kulkarni]

Checked in fix suggested by Oleg. Tested it and confirmed that it works fine.
thanks Oleg.

cvs diff CurrentPageImpl.cpp (in directory D:\M16
\mozilla\java\webclient\src_moz)
Index: CurrentPageImpl.cpp
===================================================================
RCS file: /cvsroot/mozilla/java/webclient/src_moz/CurrentPageImpl.cpp,v
retrieving revision 1.9
diff -r1.9 CurrentPageImpl.cpp
74c74
<     if (NS_FAILED(rv))  {
---
>     if (NS_FAILED(rv) || contentViewer==nsnull )  {
339c339
<         if (NS_FAILED(rv))  {
---
>         if (NS_FAILED(rv) || contentViewer==nsnull)  {

*****CVS exited normally with code 1*****

_Ashu

Comment 7

[Oleg Khokhlov]

I mark it as verified.