44797 - Sidebar links should open a New Browser window if there are none open.

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[Joseph Elwell]

Steps to reproduce:
1) Launch Mail/News
2) Make sure you have an open browser window.
3) Open the "Tinderbox" section of the sidebar in Mail/News.
4) Click on the link there.
*watch as the Browser opens that link*

Repeat with a change, this time close all mozilla windows other than Mail/News.
when you click on the link in the Tinderbox section of the sidebar in Mail/News, 
tinderbox is loaded into one of the Mail/News panes.

This is an unexpected result.

Expected Result:
If no browser window is open then one is opened with the link (whether that be 
the system default browser, or Mozilla -  note: we should not assume that 
the Mozilla browser is even installed).

Comment 1

[Joseph Elwell]

This might not look so bad in Mail/News. But in IM it's horrid, and is blocking 
an nsbeta2+ bugscape bug 1346.

from bug 32034, information that might help:
------- Additional Comments From Robert Churchill 2000-07-07 11:54 -------

Once these fixes are checked in [and currently they are not, due to being marked 
nsbeta2-, as well as the fixes need to be tweaked slightly due to other tree 
changes such as "window.content" now being "window._content"], when a search is 
done from the sidebar, instead of just setting "window._content" to something, 
instead the window mediator is used to find the nearest browser window (or open 
one if there aren't any) and use that.  If the active window IS a browser 
window, its used (so no new window in that case).

Comment 2

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 3

[Robert John Churchill]

Adding me to the status.

Comment 4

[Robert John Churchill]

This might be a good bug to have danm look at.

Dan, if you look at the page source for
    http://tinderbox.mozilla.org/seamonkey/panel.html
    (the URL for the remote HTML of the tinderbox sidebar panel)
you'll see the the anchor link has a target="_content" set in the HTML.  I'd 
suspect that somewhere, "_content" resolution goes looking for a navigator 
window which it'll use if it finds it.  However, if no browser windows are open, 
it looks like its falling back for some reason to the HTML content area in the 
mail/news window.

Comment 5

[Viswanath Ramachandran]

danm/rjc - in light of PDTs edict to have ETAs in bug reports, any idea when 
this will be fixed? thanks, Vishy. 

Comment 6

[Viswanath Ramachandran]

Yes on review, I am comfortable with nsbeta2- this one. We shd fix it for RTM 
but can live with it in nsbeta2 in interest of hitting the schedule. 

thanks, Vishy

Comment 7

[Peter Trudelle]

Doesn't fit latest 'would ya pull it off the wire' criteria, marking nsbeta2-,
nominating for nsbeta3

Comment 8

[Peter Trudelle]

nsbeta3+

Comment 9

[johng]

cc'ing slamm, me and german.

Comment 10

[Dan M]

nsBrowserInstance::HandleContent now forces a new window if the target is 
_content.

Comment 11

[Claudius Gayle]

I was nosing around bug 32034 and came across this one and thought I verify... alas it didn't go so well.

Win98 build 2000082508, doing a search from the mail sidebar search panel opens a new browser window
EVERY time AND it didn't even do my search after opening the extraneous window.

I expected my existing browser window to be used and I would hope that my search doesn't get dropped
on the floor. REOPENING
(back-pedaling, the search not happening may be because bug 32034 isn't fixed)

Comment 12

[Peter Trudelle]

resolving as fixed. Let's not morph this into two other problems.  The originial
report was about opening the link in a mail window, which is still fixed. Other
problems cited *may* be a side-effect fo this fix, but they are not *this* bug.

Comment 13

[Joseph Elwell]

marking verified. tested on linux build 2000082811.

Comment 14

[Claudius Gayle]

I didn't mean to muddle the issue with the search-related stuff.

I reopened this bug because I didn't accept the fix. Nonetheless, the new
regression is bug 50748