45060 - Addressing Area: display the background lines

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[jglick]

In the Addressing Area of Mail Compose, it would be helpful if we could display 
the background lines/grid like 4.x.

Comment 1

[jglick]

P2 per Mail UE Review.

Nominate as nsbeta3

Comment 2

[Jean-Francois Ducarroz]

Would be nice to have but we have so much else to do...

Comment 3

[lchiang]

mail6 type of nsbeta3 bug per mail triage

Comment 4

[scottputterman]

mail triage marking [nsbeta3-]

Comment 5

[scottputterman]

Sorry for the extra email. Removing mail6 keyword.

Comment 6

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8. This is only in the modern skin.

Comment 7

[Jean-Francois Ducarroz]

Classic theme already has the background line.

Comment 8

[jglick]

Modern skin should have the background lines.

Comment 9

[Jean-Francois Ducarroz]

reassign to varada

Comment 10

[scottputterman]

reassigning to hewitt. cc'ing hangas. We'd talked about giving differences in
skins to Paul's team. Feel free to reevalue the beta1 acceptance and milestone.
The current settings mean that mailnews would like this. If you guys aren't
going to be able to help out with this, please reassign this back to varada.

Comment 11

[Joe Hewitt (gone)]

I'm happy to take this since I always wanted to see those old grid lines from 
4.x come back... the question is, what is the right way to do it? In classic, 
there is only one grid line drawn because there is only one treerow to style. 
If we wanted to fully emulate the 4.x look in which the grid covers the entire 
tree, that would take some js work to create and dispose of "dummy rows" to 
fill the empty part of the grid, but go away if new addressees are added.

Comment 12

[hangas]

Themes Triage Team nsbeta1+

Comment 13

[Joe Hewitt (gone)]

I've got a working fix for this which I will post soon as patch once I refine it
a bit.  I'm cc'ing ducarroz because I had to modify his code a bit to make this
work.

As I stated in my last comment, we needed to add some "dummy rows" to the
addressing widget tree so the empty space in the tree can be filled with grid
lines for address rows that have yet to be entered.  As new addresses are
entered, the dummy rows are replaced.  This solution required just a bit of new
code in addressingWidgetOverlay.js.

Comment 14

[Joe Hewitt (gone)]

As I play with my solution as detailed below, I see some problems that I don't
think are avoidable:

1. the dummy rows created when msgcompose first fires are static, meaning that
if the tree grows (due to the splitter being adjusted) no more new rows will be
created, and thus there will be a big empty space in area that grows.  I don't
know of a way to capture an event for when a splitter is moved, but if there is
such an event then there is a way to solve this problem.

2. treerows currently are all forced to be the same size as the largest in the
tree.  Because of this, there will be some empty space at the bottom of the tree
that contains no gridlines because there's no way for me to specify that the
last tree row should fill the exact amount of space remaining.  

Comment 15

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 16

[Joe Hewitt (gone)]

Hold on that patch.  I'm going to revise it so that dummy rows are created when
the splitter is moved and when rows are deleted.

Comment 17

[Joe Hewitt (gone)]

Attachment: patch to fix (rev2)

Comment 18

[Jean-Francois Ducarroz]

good. R=ducarroz.

Comment 19

[Joe Hewitt (gone)]

sr=sspitzer

Comment 20

[Joe Hewitt (gone)]

fixed

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED FIXED on build 2001020504 (windows 2000), build 2001020513 (mac os
9.0.4) and build 2001020506 (linux redhat 7.0).

Comment 22

[Becki Sanford]

You might want to double-check the changes that were checked into -r1.45 of
addressingWidgetOverlay.js.  There's now a problem with the "To/From/CC" field
not showing up when the user enters an address then hits enter.

Comment 23

[Becki Sanford]

The following line in awAppendNewRow() is not properly being executed:

   if (nextDummy) body.removeChild(nextDummy);

Since there has not been an update to get the new item displayed before the
delete is performed, the two actions negate each other.  The result is a missing
"To/From/CC" button and the little card icon.  If the above line is replaced
with the following, it will prevent this from occurring (although it's probably
not a good fix):

   if (nextDummy) setTimeout("awFitDummyRows();",0);

Comment 24

[Ninoschka Baca]

I think the problem with the To/CC/Bcc fields not appearing are logged in 
bug# 69524.