451533 - Make sure all names are truncated throughout platform-independent module

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Adding missing aName.Truncate() calls to various ::getName methods in a11y platform independent code. Patch coming up.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 334859 [details] [diff] [review]
Patch


> NS_IMETHODIMP
> nsApplicationAccessible::GetName(nsAString& aName)
> {
>+  aName.Truncate();

nit: new line here please and below if applicable

>@@ -125,16 +125,18 @@ NS_IMETHODIMP nsRootAccessible::GetName(
>   }
> 
>   if (mRoleMapEntry) {
>     nsAccessible::GetName(aName);
>     if (!aName.IsEmpty()) {
>       return NS_OK;
>     }
>   }
>+
>+  aName.Truncate();

I would prefer to truncate the name in the begin of method if it's applicable here, fix the same below

> 
>-NS_IMETHODIMP nsXULColorPickerTileAccessible::GetName(nsAString& _retval)
>+NS_IMETHODIMP nsXULColorPickerTileAccessible::GetName(nsAString& aName)

use

NS_IMETHODIMP
nsXULColorPickerTileAccessible::GetName(nsAString& aName)

 fix the same below

> 
>-NS_IMETHODIMP nsXULMenubarAccessible::GetName(nsAString& _retval)
>+NS_IMETHODIMP nsXULMenubarAccessible::GetName(nsAString& aName)
> {
>-  _retval.AssignLiteral("Application");
>+  aName.Truncate();
>+  aName.AssignLiteral("Application");

no need to truncate it here.


let me loot at the next patch

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Patch2, addressing Surkov's comments

I now also wrapped those function headers that didn't get a parameter change, to make them all consistent.

Comment 4

[alexander :surkov (:asurkov)]

Comment on attachment 334863 [details] [diff] [review]
Patch2, addressing Surkov's comments

nice, r=me

Comment 5

[Marco Zehe (:MarcoZ)]

Pushed in changeset:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/e42742425925