45248 - profile mgr crashes if you use <ret> key to pick profile

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P1)

Description

[David :Bienvenu]

The profile mgr crashes with the classic skin this morning. I'm guessing it's
because of the profile mgr work Ben checked in last night, which had checkins
for the modern skin but not the classic skin. The modern skin works fine. The
actual bug is probably an XBL bug and we shouldn't crash if something is missing
from a skin, obviously.

Here's the stack trace:

NTDLL! 77f76274()
nsDebug::Assertion(const char * 0x01d3492c
??_C@_0DJ@KMGL@You?5can?8t?5dereference?5a?5NULL?5nsC@, const char * 0x01d34970
??_C@_0N@NHHF@mRawPtr?5?$CB?$DN?50?$AA@, const char * 0x01d34980
??_C@_0BO@LIAM@?4?4?2?4?4?2dist?2include?2nsCOMPtr?4h?$AA@, int 0x00000289) line
246 + 13 bytes
nsDebug::PreCondition(const char * 0x01d3492c
??_C@_0DJ@KMGL@You?5can?8t?5dereference?5a?5NULL?5nsC@, const char * 0x01d34970
??_C@_0N@NHHF@mRawPtr?5?$CB?$DN?50?$AA@, const char * 0x01d34980
??_C@_0BO@LIAM@?4?4?2?4?4?2dist?2include?2nsCOMPtr?4h?$AA@, int 0x00000289) line
342 + 21 bytes
nsCOMPtr<nsIDocument>::operator->() line 649 + 34 bytes
nsXBLEventHandler::ExecuteHandler(nsXBLEventHandler * const 0x0261a050, const
nsString & {...}, nsIDOMEvent * 0x0264b664) line 592 + 41 bytes
nsXBLEventHandler::KeyPress(nsIDOMEvent * 0x0264b664) line 143 + 40 bytes
nsEventListenerManager::HandleEvent(nsIPresContext * 0x02024c00, nsEvent *
0x0012f730, nsIDOMEvent * * 0x0012f510, nsIDOMEventTarget * 0x02562840, unsigned
int 0x00000007, nsEventStatus * 0x0012f69c) line 1094 + 23 bytes
nsXULElement::HandleDOMEvent(nsXULElement * const 0x02562830, nsIPresContext *
0x02024c00, nsEvent * 0x0012f730, nsIDOMEvent * * 0x0012f510, unsigned int
0x00000001, nsEventStatus * 0x0012f69c) line 3350
PresShell::HandleEventInternal(nsEvent * 0x0012f730, nsIView * 0x020660e0,
nsEventStatus * 0x0012f69c) line 3906 + 45 bytes
PresShell::HandleEvent(PresShell * const 0x02067844, nsIView * 0x020660e0,
nsGUIEvent * 0x0012f730, nsEventStatus * 0x0012f69c, int & 0x00000001) line 3841
+ 23 bytes
nsView::HandleEvent(nsView * const 0x020660e0, nsGUIEvent * 0x0012f730, unsigned
int 0x0000001c, nsEventStatus * 0x0012f69c, int & 0x00000001) line 782
nsViewManager2::DispatchEvent(nsViewManager2 * const 0x02066430, nsGUIEvent *
0x0012f730, nsEventStatus * 0x0012f69c) line 1389

Comment 1

[David :Bienvenu]

adding keywords. The crash happens after you pick a profile and click start
mozilla. I was able to get around it by running an old build, switching to the
modern skin, and then running my debug build again. When I switched back to the
classic skin, and ran again, I crashed again. Marking dogfood since I believe
the classic skin is staggeringly popular.

Comment 2

[David :Bienvenu]

OK, I'm an idiot. It just has to do with whether you press <ret> to pick the
profile instead of clicking 'start mozilla'. If you use the <ret> key, you
crash, if you click start mozilla, it works. I must have clicked start mozilla
after switching skins :-( Reassigning to hyatt, cc saari.

Comment 3

[Jay Patel [:jay]]

Putting on [nsbeta2+] radar for beta2 fix. 

Comment 4

[David Hyatt]

Giving this to ben so that he can fix the more pressing classic skin problem and 
then reassign back to me, so that i can deal with the crash at my leisure.

Comment 5

[David :Bienvenu]

I'm not sure this has to do with the classic skin at all.

Comment 6

[don]

Ben, do you need to do any work here?

Comment 7

[Claudius Gayle]

changing platform/OS to All/All. This has nothing to do with the skins. I've only used the modern skin.
Use 'enter' or 'return' instead of clicking 'Start Mozilla' and you will quit. I say 'quit' insteadof crash b/c
I notice talkback doesn't come up even though it's loaded and working properly. I've also seen this as
far back as a mac 2000071109 build as well as today's 2000071309 builds(all platforms).

Comment 8

[Stephan Niemz]

    I'm seeing this, too, on Linux in a today's build from the CVS source. And
it is a crash here (seg fault), not just a quit.

Comment 9

[lchiang]

*** Bug 45517 has been marked as a duplicate of this bug. ***

Comment 10

[Blake Ross]

If it's not skin-dependent, isn't this hyatt's now?

Comment 11

[Bernd Mielke]

*** Bug 45594 has been marked as a duplicate of this bug. ***

Comment 12

[Bernd Mielke]

Attachment: stack trace from bug 45594 under Win98

Comment 13

[Simon Fraser [no longer active]]

Bug 45665 also shows a similar crash, but with a totally different stack, and in 
the modern skin.

Comment 14

[Jay Patel [:jay]]

*** Bug 45616 has been marked as a duplicate of this bug. ***

Comment 15

[Simon Fraser [no longer active]]

*** Bug 45665 has been marked as a duplicate of this bug. ***

Comment 16

[Blake Ross]

I think hyatt's checkin completely fixed this.  Reopen if I'm wrong.

Comment 17

[Grace Bush]

verified on Linux and Windows, unable to launch on Mac (2000072113)

Comment 18

[Grace Bush]

ok on build 2000072408 Mac

Comment 19

[Nikhil Bhatla (gone)]

Bug has returned.  Check description and stdlog from bug #48038

Comment 20

[Nikhil Bhatla (gone)]

*** Bug 48038 has been marked as a duplicate of this bug. ***

Comment 21

[Peter Trudelle]

nsbeta3+

Comment 22

[leger]

Putting on [nsbeta2-] radar.  Missed the PR2 train :-(

Comment 23

[David Hyatt]

Fixed.

Comment 24

[Grace Bush]

fixed in builds 2000081609/10 M18 on all platforms