Closed
Bug 453999
Opened 16 years ago
Closed 16 years ago
Need to support places autocomplete search
Categories
(SeaMonkey :: Autocomplete, defect)
SeaMonkey
Autocomplete
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(2 files)
|
1.72 KB,
patch
|
ajschult784
:
review+
|
Details | Diff | Splinter Review |
|
809 bytes,
patch
|
ajschult784
:
review+
|
Details | Diff | Splinter Review |
Autocompleting from places doesn't work quite right yet.
|
Assignee | |
Comment 1•16 years ago
|
||
By bailing out early at the start of the search we can also simplify the search failed code.
|
|
Assignee | |
Comment 2•16 years ago
|
||
Whoops, I forgot to explain the reason for this patch. Traditionally autocomplete datasources simply used to fail when passed an empty search string. However the Firefox designers had the bright idea to overload the search to produce their location bar history instead.
|
|
Assignee | |
Comment 3•16 years ago
|
||
I discovered another bug - places tests the async code (it only ever returns results async) and in this case I wasn't clearing the counts with the results.
Attachment #337239 -
Flags: review?(ajschult)
|
||
Updated•16 years ago
|
Attachment #337222 -
Flags: review?(ajschult) → review+
|
|
||
Comment 4•16 years ago
|
||
Comment on attachment 337222 [details] [diff] [review] Proposed patch r=ajschult
|
|
||
Updated•16 years ago
|
Attachment #337239 -
Flags: review?(ajschult) → review+
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 337239 [details] [diff] [review] Fix incremental results oof
|
|
Assignee | |
Comment 6•16 years ago
|
||
Pushed changeset 55504b35cd77 to mozilla-central. Pushed changeset 1d58ae237bdc to mozilla-central. KaiRo, do you have any other issues with places autocomplete?
|
||
Comment 7•16 years ago
|
||
From a small amount of preliminary testing today, the issues I saw seems to be fixed - thanks a lot!
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/1d8477b3472d Bail out early when the autocomplete field is empty r=ajschult https://hg.mozilla.org/comm-central/rev/e19a28d45911 Fix handling of partial autocomplete results r=ajschult
You need to log in
before you can comment on or make changes to this bug.
Description
•